890755 - sidebar.js throws TypeError ("sidebar is null") when browser dialogs are closed

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P2)

Description

[nodeless]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:22.0) Gecko/20100101 Firefox/22.0 (Beta/Release)
Build ID: 20130618035212

Steps to reproduce:

1. Have a sidebar showing
2. Open Tools->Options dialog
3. Close tools options


Actual results:

TypeError exception can be observed in console output:

TypeError: sidebar is null
resource://extensions.modules.jid1-1c22ebonitpmyw-at-jetpack.commonjs.path/sdk/ui/sidebar.js 207
Traceback (most recent call last):
  File "resource://extensions.modules.jid1-1c22ebonitpmyw-at-jetpack.commonjs.path/sdk/deprecated/errors.js", line 23, in exports.catchAndLog/<
    return callback.apply(this, arguments);
  File "resource://extensions.modules.jid1-1c22ebonitpmyw-at-jetpack.commonjs.path/sdk/deprecated/window-utils.js", line 149, in observe
    this._unregWindow(window);
  File "resource://extensions.modules.jid1-1c22ebonitpmyw-at-jetpack.commonjs.path/sdk/deprecated/window-utils.js", line 114, in _unregWindow
    this._delegate.onUntrack(window);
  File "resource://extensions.modules.jid1-1c22ebonitpmyw-at-jetpack.commonjs.path/sdk/ui/sidebar.js", line 207, in Sidebar<.setup/internals.tracker<.onUntrack
    let panelBrowser = sidebar.contentDocument.getElementById(WEB_PANEL_BROWSER_ID);



Expected results:

No exception should be thrown.

Comment 1

[Erik Vold [:erikvold] (please needinfo? me)]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1084

Pointer to Github pull-request

Comment 2

[Erik Vold [:erikvold] (please needinfo? me)]

(In reply to nodeless from comment #2)

Thanks for the report nodeless! you saved me and others from a future headache..

Comment 3

[Erik Vold [:erikvold] (please needinfo? me)]

Comment on attachment 771895 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1084

Moving my review requests from Matteo to someone else.

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/a7135946caa43feb6ab439cadd44492b1ac99da8
Bug 890755: sidebar.js throws TypeError ("sidebar is null") when browser dialogs are closed

https://github.com/mozilla/addon-sdk/commit/19f496beec2b21f4e1528ef515c16133eb520d54
Merge pull request #1084 from erikvold/890755

Bug 890755: sidebar.js throws TypeError ("sidebar is null") when browser dialogs are closed r=@ZER0

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I'm going through the list of open bugs that github robot has commented in. Is this bug fixed, Matteo?

Comment 6

[Matteo Ferretti [:zer0] [:matteo]]

(In reply to Wes Kocher (:KWierso) from comment #5)
> I'm going through the list of open bugs that github robot has commented in.
> Is this bug fixed, Matteo?

Yes, we merged with master, we can mark as fixed.