89076 - remove unnecessary methods from nsIObjectFrame

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect, P4)

Description

[Chris Waterson]

Somehow nsIObjectFrame wound up with a bunch of nsIFrame methods that it doesn't
really want to expose to the outside world. Here is a patch to remove them.

Comment 1

[Chris Waterson]

Attachment: remove unneeded methods from nsIObjectFrame

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

r=dbaron if it compiles without any other changes...

Comment 3

[Chris Waterson]

heikki, I just realized that you checked in nsIObjectFrame.h. Why did you expose
all of the nsIFrame methods there? The only relevant method that's used outside
layout seems to be |GetPluginInstance()|.

Comment 4

[Heikki Toivonen (remove -bugzilla when emailing directly)]

I probably didn't think it through... But the frames are so strange that I might
have decided to go with full member list to be on the safe side (with all the
typecasts, no refcounts etc.).

I think this same problem might be found in nsIImageFrame.

Comment 5

[Marc Attinasi]

sr=attinasi

Comment 6

[Chris Waterson]

Fix checked in. I'll file another bug for nsIImageFrame.

Comment 7

[shrirang khanzode]

v