890776 - [System] Call screen orientation changes on incoming call during Youtube.com video playback

Status: RESOLVED FIXED

Description

[Leo]

Created attachment 771923 [details]
Repro video

Description: Call screen orientation changes on incoming call during Youtube.com video playback
Expected: Call screen is expected to be portrait the whole time.
Gaia revision: f2d6ed54a236e6e3b94f0abad9f0dacb8a1cc7b3
Personal email id:  [e-mail]
Frequency rate: 100%


Repro steps:

1. Start Youtube.com video playback.
2. Rotate the device to make it landscape.
3. Use 2nd device to call 1st device.
4. Observe the call screen rotates on incoming call.

Comment 1

[Leo]

Probably related bugs: 869335, 851642, 843390

Comment 2

[(inactive after 6/18) Alive Kuo [:alive]]

v1-train commit d336288e6cda1a8f974ceea41b9d7860c2367d1f

I cannot reproduce this but I see the inline activity resize fails...

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Alive Kuo [:alive] from comment #2)
> v1-train commit d336288e6cda1a8f974ceea41b9d7860c2367d1f
> 
> I cannot reproduce this but I see the inline activity resize fails...

OK I reproduced. The browser app needs to be oriented to landscape before calling video activity.

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

This looks to me:
(1) Video activity closes itself when call-screen comes
(2) gecko unlocks the orientation, which was just locked by attention_screen(to portrait-primary)

It's strange why 851642 doesn't fix this.

Comment 5

[John Hu [:johnhu][:johu][:醬糊小弟]]

Created attachment 771966 [details]
prevent restore orientation when stopping inline activity and attention screen is shown

In stopInlineActivity, I added the code to check if attention screen is shown. If the attention screen is shown, the running app is still not visible and no need to change orientation for the displayed running app.

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 771966 [details]
prevent restore orientation when stopping inline activity and attention screen is shown

Good! The direction is correct but you still need to do screenElement.classList.remove('inline-activity'); when there're no inline activities.

Please fix this.

Comment 7

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 771966 [details]
prevent restore orientation when stopping inline activity and attention screen is shown

already fix the patch.

Comment 8

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 771966 [details]
prevent restore orientation when stopping inline activity and attention screen is shown

r- for github comment.

Comment 9

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 771966 [details]
prevent restore orientation when stopping inline activity and attention screen is shown

change to another way of implementing this patch.

Comment 10

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 771966 [details]
prevent restore orientation when stopping inline activity and attention screen is shown

r+, thanks for your patience.

Comment 11

[John Hu [:johnhu][:johu][:醬糊小弟]]

merged to master:
https://github.com/mozilla-b2g/gaia/commit/3d6099fad24540d6eed33c2e4414f55d64d3b541

Comment 12

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 3d6099fad24540d6eed33c2e4414f55d64d3b541 to:
v1-train: 1442e63ebffa29df7a02b1e5515d22bb44f05492

Comment 13

[Cody Roesch [:croesch]]

Verified as fixed on the Leo device on the variables below. When calling the device during youtube.com playback in Landscape mode, Portrait mode, Fullscreen video or Windowed video, all videos retain their orientation as you would expect.

Environmental Variables
Build ID: 20130717070237
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/582e3a7018b0
Gaia: c506c50adaaebcf729ac3c27887ba2931ab79040
Platform Version: 18.1
RIL Version: 01.01.00.019.158

Comment 14

[John Ford [:jhford] CET/CEST Berlin Time]

v1.1.0hd: 1442e63ebffa29df7a02b1e5515d22bb44f05492