890784 - Split jscntxt{.h,inlines.h,.cpp} in two

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Nicholas Nethercote [inactive]]

jscntxt.h contains both JSContext and JSRuntime.  In this bug I'll split JSRuntime out into a separate module.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: (part 1) - Create a new vm/Runtime module and put JSRuntime in it.

I did |hg cp jscntxt.h vm/Runtime.h|, and then removed the unneeded bits from
each file.  And likewise for the other files.  This means the diff mostly
contains removed lines.

The only unexpected change is that the RuntimeAllocPolicy() constructor that
takes a |JSContext*| had to be removed.  Not a big deal.

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: (part 2) - Fix up #includes after the creation of the vm/Runtime module.

I used include-what-you-use to do this, which made it pretty easy and gives me
confidence it's right.

Comment 3

[Nicholas Nethercote [inactive]]

billm: I'd appreciate a fast review, if possible, because these patches will rot quickly.  Please let me know if you are busy and I'll find someone else to do them.

Comment 4

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 771942 [details] [diff] [review]
(part 1) - Create a new vm/Runtime module and put JSRuntime in it.

Thanks for doing this.

Comment 5

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/740cea2dbf45
https://hg.mozilla.org/integration/mozilla-inbound/rev/a8929e61d50a

Thanks for the fast review.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/740cea2dbf45
https://hg.mozilla.org/mozilla-central/rev/a8929e61d50a