89083 - nsBrowserContentHandler::GetDefaultArgs() is being called twice (causing bugscape bug #4428)

Status: RESOLVED FIXED

(SeaMonkey :: General, defect, P2)

Description

[(not reading, please use [e-mail] instead)]

morse's comment from bugscape 

"What seems to be happening is that the nsBrowserContentHandler::GetDefaultArgs 
method in nsBrowserInstance.cpp is being called twice.  The first time it 
fetches the override url properly and it sets the override pref so that the 
override never occurs again.  That is correct behavior because we only want the 
Whats-New screen to appear once in the lifetime of the browser.  But when this 
method is called the second time, the fact that the override pref is now false 
causes the normal startup page to be fetched."

http://bugscape.netscape.com/show_bug.cgi?id=4428

there's a patch for this on the 0.9.2 branch, but has been rejected for the 
trunk.

this bug tracks the real fix.

Comment 1

[Viswanath Ramachandran]

moving to mozilla1.0. 

Comment 2

[Paul Chen]

nav triage team:

It's starting to get annoying patching around this bug for releases, moving to
mozilla0.9.4, let's get this thing fixed once and for all

Comment 3

[(not reading, please use [e-mail] instead)]

didn't this get fixed?

Comment 4

[jag (Peter Annema)]

This should be fixed. Taking bug from alecf.

Comment 5

[jag (Peter Annema)]

And marking fixed. There should now only be one call to GetDefaultArgs().

doron, I'm placing racham as the QA on this, I believe he knows how to verify
that this bug is fixed.

Racham, could you verify that this bug is indeed fixed? Thanks.