Impossible to press Enter in "Password Entry Dialog"

VERIFIED FIXED in psm2.1

Status

defect
P2
normal
VERIFIED FIXED
18 years ago
3 years ago

People

(Reporter: bugzilla, Assigned: inactive-mailbox)

Tracking

1.0 Branch
psm2.1
x86
Windows 2000

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

18 years ago
When you try to restore a certificate you get a password dialog "Password Entry 
Dialog".
If you enter a password in this dialog and press Enter nothing happens. It seems 
that the dialog doesn't accept Enter as a Ok.

Enter should be the same a hitting the Ok button.

build 20010702

Comment 1

18 years ago
target 2.1
Priority: -- → P2
Target Milestone: --- → 2.1
Version: 1.01 → 2.0
This bug seems to apply to all PSM preferences dialogs.

I'm not sure how to enable this functionality, need to research.
The default="true", which I expected to provide it, only makes the button have a
larger border.
-> Kai
Assignee: ssaux → kai.engert
David, please review.
Status: NEW → ASSIGNED

Comment 6

18 years ago
r=ddrinan.
(Reporter)

Comment 7

18 years ago
seeking sr from blizzard
Isn't there a common dialog class you can inherit from that does this for you? 
If there isn't then sr=blizzard

Comment 9

18 years ago
Kai, Can you ask on #mozilla about the hypothetical class?
There is something that could be used: platformDialogOverlay. But this is not a
dialog class, but more a collection of includable snippet. I think we could
rewrite the PSM dialogs to use those snippets, but that would require rewriting
the PSM dialogs even further, and it even might be required to enhance the
snippets to work with our need (current design) to have disabled OK buttons in
certain input states, add onLoad functions to all our dialogs on set callbacks
functions to be called by the included buttons.

On the other hand, if you look at
http://lxr.mozilla.org/seamonkey/search?string=dosetokcancel many Mozilla
dialogs seem to use those common code.
I suggest to accept this patch now and open another bug, called "PSM dialog
button cleanup".
open the bug to cleanup the psm dialogs and you can have an sr=blizzard

Comment 12

18 years ago
Created bug 89674 as per blizzard suggestion.

Comment 13

18 years ago
adding nsenterprise to all P1, P2 PSM bugs with target milestone of 2.1
Keywords: nsenterprise
(Reporter)

Comment 14

18 years ago
I'll say again: just needs checkin...
Keywords: nsenterprisepatch

Comment 15

18 years ago
needs a= from drivers
adding approval keyword.
Keywords: approval

Comment 16

18 years ago
Mass assigning QA to ckritzer.
QA Contact: junruh → ckritzer

Comment 17

18 years ago
Checked in patch for Kai.
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED

Comment 18

18 years ago
keywords->verifyme

Comment 19

18 years ago
Verified on 8/2 WinNT trunk.
Status: RESOLVED → VERIFIED

Updated

14 years ago
Component: Security: UI → Security: UI
Product: PSM → Core

Updated

11 years ago
Version: psm2.0 → 1.0 Branch
Keywords: verifyme
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.