11.25 KB, patch
|Details | Diff | Splinter Review|
When you try to restore a certificate you get a password dialog "Password Entry Dialog". If you enter a password in this dialog and press Enter nothing happens. It seems that the dialog doesn't accept Enter as a Ok. Enter should be the same a hitting the Ok button. build 20010702
Priority: -- → P2
Target Milestone: --- → 2.1
Version: 1.01 → 2.0
This bug seems to apply to all PSM preferences dialogs. I'm not sure how to enable this functionality, need to research. The default="true", which I expected to provide it, only makes the button have a larger border.
Assignee: ssaux → kai.engert
Created attachment 41312 [details] [diff] [review] Patch to fix this in (hopefully) all afftected PSM dialogs
David, please review.
Status: NEW → ASSIGNED
seeking sr from blizzard
Isn't there a common dialog class you can inherit from that does this for you? If there isn't then sr=blizzard
Kai, Can you ask on #mozilla about the hypothetical class?
There is something that could be used: platformDialogOverlay. But this is not a dialog class, but more a collection of includable snippet. I think we could rewrite the PSM dialogs to use those snippets, but that would require rewriting the PSM dialogs even further, and it even might be required to enhance the snippets to work with our need (current design) to have disabled OK buttons in certain input states, add onLoad functions to all our dialogs on set callbacks functions to be called by the included buttons. On the other hand, if you look at http://lxr.mozilla.org/seamonkey/search?string=dosetokcancel many Mozilla dialogs seem to use those common code. I suggest to accept this patch now and open another bug, called "PSM dialog button cleanup".
open the bug to cleanup the psm dialogs and you can have an sr=blizzard
Created bug 89674 as per blizzard suggestion.
adding nsenterprise to all P1, P2 PSM bugs with target milestone of 2.1
I'll say again: just needs checkin...
Keywords: nsenterprise → patch
needs a= from drivers adding approval keyword.
Mass assigning QA to ckritzer.
QA Contact: junruh → ckritzer
Checked in patch for Kai.
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED
Keywords: approval, patch → nsenterprise, verifyme
Verified on 8/2 WinNT trunk.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.