89086 - Impossible to press Enter in "Password Entry Dialog"

Status: VERIFIED FIXED

(Core Graveyard :: Security: UI, defect, P2)

Description

[Henrik Gemal]

When you try to restore a certificate you get a password dialog "Password Entry 
Dialog".
If you enter a password in this dialog and press Enter nothing happens. It seems 
that the dialog doesn't accept Enter as a Ok.

Enter should be the same a hitting the Ok button.

build 20010702

Comment 1

[Stephane Saux]

target 2.1

Comment 2

[(Don't use, old account) - Kai Engert]

This bug seems to apply to all PSM preferences dialogs.

I'm not sure how to enable this functionality, need to research.
The default="true", which I expected to provide it, only makes the button have a
larger border.

Comment 3

[(Don't use, old account) - Kai Engert]

-> Kai

Comment 4

[(Don't use, old account) - Kai Engert]

Attachment: Patch to fix this in (hopefully) all afftected PSM dialogs

Comment 5

[(Don't use, old account) - Kai Engert]

David, please review.

Comment 6

[David P. Drinan]

r=ddrinan.

Comment 7

[Henrik Gemal]

seeking sr from blizzard

Comment 8

[Christopher Blizzard (:blizzard)]

Isn't there a common dialog class you can inherit from that does this for you? 
If there isn't then sr=blizzard

Comment 9

[Stephane Saux]

Kai, Can you ask on #mozilla about the hypothetical class?

Comment 10

[(Don't use, old account) - Kai Engert]

There is something that could be used: platformDialogOverlay. But this is not a
dialog class, but more a collection of includable snippet. I think we could
rewrite the PSM dialogs to use those snippets, but that would require rewriting
the PSM dialogs even further, and it even might be required to enhance the
snippets to work with our need (current design) to have disabled OK buttons in
certain input states, add onLoad functions to all our dialogs on set callbacks
functions to be called by the included buttons.

On the other hand, if you look at
http://lxr.mozilla.org/seamonkey/search?string=dosetokcancel many Mozilla
dialogs seem to use those common code.
I suggest to accept this patch now and open another bug, called "PSM dialog
button cleanup".

Comment 11

[Christopher Blizzard (:blizzard)]

open the bug to cleanup the psm dialogs and you can have an sr=blizzard

Comment 12

[Stephane Saux]

Created bug 89674 as per blizzard suggestion.

Comment 13

[Stephane Saux]

adding nsenterprise to all P1, P2 PSM bugs with target milestone of 2.1

Comment 14

[Henrik Gemal]

I'll say again: just needs checkin...

Comment 15

[Stephane Saux]

needs a= from drivers
adding approval keyword.

Comment 16

[John Unruh]

Mass assigning QA to ckritzer.

Comment 17

[Javier Delgadillo]

Checked in patch for Kai.

Comment 18

[Stephane Saux]

keywords->verifyme

Comment 19

[John Unruh]

Verified on 8/2 WinNT trunk.