890862 - Wrong ril.data.apnSettings when carrier is not in apn.json

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[John Hu [:johnhu][:johu][:醬糊小弟]]

This bug only occurs when simcard is unknown carrier. We use apn.json file to build default settings. If carrier is not known by apn.json, the apnSettings will be [[]] and the settings built by Bug 842252 will be empty, too.

STR:
1. reset the phone, and stay power off.
2. insert a simcard whose carrier is not in apn.json.
3. boot up the phone.

Comment 1

[John Hu [:johnhu][:johu][:醬糊小弟]]

Attachment: add a new apn item when APN with the same type is not found

I create a flag to mark if a APN with the same type is found from previous settings. If it is not found, we create one for it.

Comment 2

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 772012 [details]
add a new apn item when APN with the same type is not found

Ken, 

Please help us to make try this patch.

Comment 3

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 772012 [details]
add a new apn item when APN with the same type is not found

There is a potential bug in operator_variant.js. We use mcc and mnc to check if we need to reconstruct the APN settings, including new and old.

If we upgrade to new version with the same simcard, the new APN settings will not be reconstructed because mcc and mnc is the same.

I will merge the patch in this bug and reset the review and feedback flag.

Comment 4

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 772012 [details]
add a new apn item when APN with the same type is not found

1. I create a flag to mark if a APN with the same type is found from previous settings. If it is not found, we create one for it.
2. I add more check on APN Settings when system boot-up. If mcc and mnc is not changed, but APN Settings is empty, we will create a set of APN settings.

Comment 5

[José Antonio Olivera Ortega [:jaoo]]

(In reply to John Hu [:johnhu] from comment #4)
> Comment on attachment 772012 [details]

> 2. I add more check on APN Settings when system boot-up. If mcc and mnc is
> not changed, but APN Settings is empty, we will create a set of APN settings.

Hey John, I don't understand this second issue. If the user doesn't change the ICC card and there were no APN settings on the first boot for that ICC card (for the mcc and mnc codes in the ICC card) there won't be APN settings for subsequent boots. Am I right?

I guess you meant what you explained above.

> If we upgrade to new version with the same simcard, the new APN settings will not
> be reconstructed because mcc and mnc is the same.

The user typically will upgrade the phone by flashing it so I guess the second issue is not a big problem. Wdyt?

Comment 6

[John Hu [:johnhu][:johu][:醬糊小弟]]

Jose, 

When user uses OTA to upgrade their phone, the mozSettings will not be reset. So, the mnc and mcc are still the same, but the apnSettings will not be built at the first boot up after upgrade.

But if user upgrade the phone by flashing a new image, it resets all data in mozSettings. In this case, the second bug doesn't exist.

Comment 7

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 772012 [details]
add a new apn item when APN with the same type is not found

r=me. Thanks John!

Comment 8

[Ken Chang[:kenkai]]

Comment on attachment 772012 [details]
add a new apn item when APN with the same type is not found

It works in my image now. But if you modify this patch, please let me know.

Comment 9

[John Hu [:johnhu][:johu][:醬糊小弟]]

Ken, 

Thanks, I will.

Comment 10

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 772012 [details]
add a new apn item when APN with the same type is not found

Thanks John. r=me.

Comment 11

[John Hu [:johnhu][:johu][:醬糊小弟]]

merged to master:

https://github.com/mozilla-b2g/gaia/commit/ad0faa24b70343599ac9a948286ab869beba37db