Closed Bug 890869 Opened 11 years ago Closed 11 years ago

@1.5x assets are required for FM Radio app.

Categories

(Firefox OS Graveyard :: Gaia::FMRadio, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::FMRadio
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:hd+, b2g18 unaffected, b2g18-v1.0.0 unaffected, b2g18-v1.0.1 unaffected, b2g-v1.1hd fixed)

Status:
VERIFIED FIXED
Project Flags:
blocking-b2g hd+
Tracking Flags:
Tracking Status
b2g18 --- unaffected
b2g18-v1.0.0 --- unaffected
b2g18-v1.0.1 --- unaffected
b2g-v1.1hd --- fixed

People

(Reporter: rexboy, Assigned: rexboy)

References

Details

(Whiteboard: [GAIA_HD_ASSETS])

Attachments

(1 file)

patch
188 bytes, text/html
timdream
: review+
Details
+++ This bug was initially created as a clone of Bug #881147 +++ We need @1.5x assets to be provided for FM radio app. Currently we just put lacked assets shrunk from @2x, which is not ideal in quality. Lacked assets (inside apps/fm/style/images/) are: dial-notches@1.5x.png fav-star-selected@1.5x.png fav-star@1.5x.png headset@1.5x.png play@1.5x.png popup-texture@1.5x.png reflection-56@1.5x.png reflection-72@1.5x.png seekdown@1.5x.png seekup@1.5x.png selector@1.5x.png spinner-FMRadio@1.5x.png stop@1.5x.png toggle-fav-star-off@1.5x.png toggle-fav-star-on@1.5x.png toggle-fav-star-pressed@1.5x.png Also, the app icon(fm@1.5x.png) in hd1.1.0 branch should also be revised. (fm@1.5x.png in master branch is up-to-date)
Summary: hdpi/xhdpi resolution assets and layout for FM Radio app → @1.5x assets are required for FM Radio app.
Attached file patch —
This is a image only PR which can be uplifted to HD branch directly. Tim, may you help review it? Thanks a lot!
Attachment #776250 - Flags: review?(timdream)
Comment on attachment 776250 [details] patch Something wrong with dial-notches@1.5x.png
Attachment #776250 - Flags: review?(timdream)
Whiteboard: [HD_ASSETS]
Whiteboard: [HD_ASSETS] → [GAIA_HD_ASSETS]
Comment on attachment 776250 [details] patch Updated. Tim may you review it again? Thanks a lot!
Attachment #776250 - Flags: review?(timdream)
Attachment #776250 - Flags: review?(timdream) → review+
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: