890900 - [compare-locales] review printf errors, at least multiple "%1$s %1$s" should be ok

Status: RESOLVED FIXED

Description

[Axel Hecht [:Pike]]

bug 438688 allows to request the same parameter more than once, so "%1$s %1$s" should be legal.

Might be good to review the other constraints in Check.py, too.

Comment 4

[Axel Hecht [:Pike]]

Created attachment 8903317 [details]
bug 890900, multiple %1$S in printf are OK,

This corresponds to bug 438688 and a GTEST like

  // Double referencing existing argument works
  out.Adopt(nsTextFormatter::smprintf(u"%1$S %1$S", u"1"));
  EXPECT_STREQ("1 1", NS_ConvertUTF16toUTF8(out).get());

from bug 1388789.

I'd test this if I had corresponding tests on the gecko impl,
but those are hard to get to.

Review commit: https://reviewboard.mozilla.org/r/175112/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/175112/

Comment 5

[Staś Małolepszy :stas]

Comment on attachment 8903317 [details]
bug 890900, multiple %1$S in printf are OK,

https://reviewboard.mozilla.org/r/175112/#review180178

Comment 6

[Axel Hecht [:Pike]]

Comment on attachment 8903317 [details]
bug 890900, multiple %1$S in printf are OK,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/175112/diff/1-2/

Comment 7

[Axel Hecht [:Pike]]

https://hg.mozilla.org/l10n/compare-locales/rev/43bdbd3bcf193d056862f9531e302b784398b2ac, marking FIXED.