890920 - Pass in --utility-path and --certificate-path to b2g mochitest mozharness script

Status: RESOLVED INVALID

(Release Engineering :: General, defect)

Description

[Andrew Halberstadt [:ahal]]

With the refactor in bug 865349 we no longer use the super hacky hardcoded method of finding the bin/certs dirs used by automation.py.in. This means we'll have to pass them in manually via command line.

Comment 1

[Andrew Halberstadt [:ahal]]

Attachment: Patch 1.0 - add command line paths

Pushed to ash out of an abundance of caution and waiting for results:
https://tbpl.mozilla.org/?tree=Ash&rev=099d4bccd08e

Comment 2

[Jonathan Griffin (:jgriffin)]

Comment on attachment 772079 [details] [diff] [review]
Patch 1.0 - add command line paths

Review of attachment 772079 [details] [diff] [review]:
-----------------------------------------------------------------

Seems to do the right thing, but can't tell from ash...looks like something Bad happened during the last merge.

Comment 3

[Andrew Halberstadt [:ahal]]

That ash problem got cleared up, but it looks like this patch actually is causing bustage.. sigh, https://tbpl.mozilla.org/php/getParsedLog.php?id=25039124&tree=Ash

Looks like the binaries in the utility path are either the wrong format, or the runtestsb2g.py script is using utility path in the wrong way.

Comment 4

[Andrew Halberstadt [:ahal]]

Comment 3 is happening because the non-patched version of runreftestb2g.py is using the utilityPath to find xpcshell: http://mxr.mozilla.org/mozilla-central/source/testing/mochitest/runtestsb2g.py#474

The refactor in bug 865349 fixes the problem (which is why I never noticed it until pushing to Ash). All this means is that this patch will need to land at the same time as bug 865349.

Comment 5

[Andrew Halberstadt [:ahal]]

I ended up writing the patch in bug 865349 such that this patch was no longer needed.