890928 - Crash when creating object url in subworker

Status: RESOLVED FIXED

(Core :: DOM: Workers, defect)

Description

[pieter-jan.speelmans]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:22.0) Gecko/20100101 Firefox/22.0 (Beta/Release)
Build ID: 20130618035212

Steps to reproduce:

Create a web worker (worker1) which spawns a new web worker (worker2) and sends it a message.
Let worker2 create a objectURL.

I made you a fiddle with a "Crash firefox"-button: http://jsfiddle.net/HmNLP/


Actual results:

Firefox crashes


Expected results:

Firefox shouldn't crash... and make my objectURL

Comment 1

[:Gijs (he/him)]

This WFM on Nightly. Can you please post one/more crash IDs? You can find them by going to about:crashes in your browser. Thank you! :-)

Comment 2

[:Gijs (he/him)]

I can, however, reproduce on beta: https://crash-stats.mozilla.com/report/index/2923ba5c-81e4-403b-bae1-ec0402130708 ...

Comment 3

[David Teller [:Yoric] - still alive but not very active]

Might be related to bug 883784.

Comment 4

[pieter-jan.speelmans]

This?
https://crash-stats.mozilla.com/report/index/d04cfef1-da40-495a-998c-8154a2130708

Comment 5

[David Teller [:Yoric] - still alive but not very active]

Definitely looks like bug 883784.

Comment 6

[:Gijs (he/him)]

(In reply to David Rajchenbach Teller [:Yoric] from comment #5)
> Definitely looks like bug 883784.

Yes, getting a nightly that doesn't have that at the minute. Maybe we want to uplift that if the crash is web-triggerable? It's already on Aurora now, I can't judge whether that's a patch that we could safely land on beta.

Comment 7

[:Gijs (he/him)]

Confirmed. Yoric, wanna see if we can land that on beta?

(I don't actually know what to do with this bug now... technically it's FIXED, I guess? Confirming for now... :-\ )

Comment 8

[David Teller [:Yoric] - still alive but not very active]

We should see that with baku.

Comment 9

[Andrea Marchesini [:baku]]

Attachment: patch

Comment 10

[Andrea Marchesini [:baku]]

bug 883784 is needed but it's not enough. Here a patch to fix this issue.

Comment 11

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 772111 [details] [diff] [review]
patch

Review of attachment 772111 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f48599a7efa2

Friendly reminder - commit messages should be summarizing what the patch is doing, not just blindly restating the bug summary.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Backed out for B2G mochitest orange.
https://hg.mozilla.org/integration/mozilla-inbound/rev/becae65c3e08

https://tbpl.mozilla.org/php/getParsedLog.php?id=25232368&tree=Mozilla-Inbound

Comment 14

[Andrea Marchesini [:baku]]

https://tbpl.mozilla.org/?tree=Try&rev=8970065a78fe

I don't see any problem in try... Could it be something else?

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/projects/birch/rev/d8a89848224b

Comment 16

[Ryan VanderMeulen [:RyanVM]]

(In reply to Andrea Marchesini (:baku) from comment #14)
> https://tbpl.mozilla.org/?tree=Try&rev=8970065a78fe
> 
> I don't see any problem in try... Could it be something else?

It's there...B2G mochitest-9. And shockingly, it broke on birch too. Backed out.
https://hg.mozilla.org/projects/birch/rev/befbe3aa46fc

Comment 17

[Andrea Marchesini [:baku]]

Attachment: patch

https://tbpl.mozilla.org/?tree=Try&rev=eb5424d8fae3

Comment 18

[Andrea Marchesini [:baku]]

https://tbpl.mozilla.org/?tree=Try&rev=598384d65354

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b96c56413b5e

Comment 20

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b96c56413b5e