Closed Bug 891018 Opened 11 years ago Closed 11 years ago

CSS cursor property does not work properly on disabled inputs

Categories

(Core :: Layout: Form Controls, defect, P2)

22 Branch
x86
All
defect

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: hmcgonig, Assigned: MatsPalmgren_bugz)

References

()

Details

(Keywords: regression, Whiteboard: [good first verify])

Attachments

(1 file)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_7_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/27.0.1453.116 Safari/537.36

Steps to reproduce:

Apply any cursor style to a disabled input. I used cursor: not-allowed;

JS fiddle for an example: http://jsfiddle.net/MGxqP/1/


Actual results:

The cursor style only shows while hovering over the disabled input's padding, not while inside the actual input.


Expected results:

The whole input should display the new cursor style when hovered.
This seems to be a regression, I just tried this in FF 19 and it works just fine.
OS: Mac OS X → All
Basic testcase:
data:text/html,<input disabled style="cursor: not-allowed">

The regression range is

Last good nightly: 2013-02-16
First bad nightly: 2013-02-17

Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=7bd555e2acfa&tochange=c4de6de47382
Bug 841828 is the obvious one...
Assignee: nobody → mounir
Blocks: 841828
Status: UNCONFIRMED → NEW
Component: Untriaged → Layout: Form Controls
Ever confirmed: true
Keywords: regression
Product: Firefox → Core
Mounir, repeating my question from duped bug 929988:

Why do we need the "> .anonymous-div" in those selectors?
Wouldn't this be sufficient:

input:disabled, textarea:disabled {
  cursor: default;
}
Flags: needinfo?(mounir)
Priority: -- → P2
(In reply to Mats Palmgren (:mats) from comment #6)
> Mounir, repeating my question from duped bug 929988:
> 
> Why do we need the "> .anonymous-div" in those selectors?
> Wouldn't this be sufficient:
> 
> input:disabled, textarea:disabled {
>   cursor: default;
> }

I honestly can't remember if there is a reason why the rule is using "> .anonymous-div".
Flags: needinfo?(mounir)
Attached patch fixSplinter Review
OK, this seems to work as expected for
  data:text/html,<input disabled style="cursor: not-allowed">
and
  data:text/html,<input disabled>
Assignee: mounir → matspal
Attachment #826066 - Flags: review?(bzbarsky)
Comment on attachment 826066 [details] [diff] [review]
fix

r=me
Attachment #826066 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/2721917a1b53
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Verified on x86_64 Win7 using the latest nightly build and found it is fixed.
This bug still exists on Firefox 26.0.  Can be recreated by initial comment's JS Fiddle.
This definitely isn't resolved in Firefox 26.0. I noticed it when trying to use Amazon's login page. They use that feature to disable their password field if you select New Account. I confirmed this works fine in Chrome 31 and IE11 but not FF26.
> This definitely isn't resolved in Firefox 26.0.

Sure.  That's why the target milestone field says "Firefox 28", which is where it's resolved.
Whiteboard: [good first verify]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: