891123 - Canvas crash due to too much recursion in SkPathStroker::cubic_to

Status: VERIFIED FIXED

(Core :: Graphics, defect)

Description

[Jesse Ruderman]

Attachment: testcase (crashes Firefox when loaded)

https://crash-stats.mozilla.com/report/index/5d972e43-5bf8-43c3-b946-82dd32130708

Happens on Windows but not on Mac.

Happens on Nightly but not on release channel (Firefox 22).

Comment 1

[Scoobidiver (away)]

No crash for me on Windows 7. Is there a graphics pref to set?

Comment 2

[Jesse Ruderman]

Attachment: graphics info (about:support)

Comment 3

[Jesse Ruderman]

I can reproduce on my other Windows machine after forcing it to use skia:
  user_pref("gfx.direct2d.disabled", true);

Comment 4

[Alice0775 White]

Regression window(m-c)
Good:
http://hg.mozilla.org/mozilla-central/rev/2cae857c17cb
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20130703 Firefox/25.0 ID:20130703061408
Bad:
http://hg.mozilla.org/mozilla-central/rev/dcbbfcdf7bb4
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20130703 Firefox/25.0 ID:20130703111528
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=2cae857c17cb&tochange=dcbbfcdf7bb4


Regression window(m-i)
Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/5f652fba751d
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20130703 Firefox/25.0 ID:20130703062507
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/73da858ef7ab
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20130703 Firefox/25.0 ID:20130703071637
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=5f652fba751d&tochange=73da858ef7ab

Suspected:  Bug 848491

Comment 5

[George Wright (:gw280) (needinfo me!)]

Attachment: upstream fix

Comment 6

[George Wright (:gw280) (needinfo me!)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6127dd6a6038

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/6127dd6a6038

Comment 8

[Ekanan Ketunuti]

Mozilla/5.0 (Windows NT 6.1; rv:25.0) Gecko/20100101 Firefox/25.0 buildid 20130910004002
opening attachment 772342 [details] and see no crashes