891170 - [leo][System][calendar] In the date picker of the calendar app, the text in the Month field overlaps with the day

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Swaroopa Vantipalli [:swaroopa]]

Attachment: Screenshot

Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/8c0127cc7be3
Gaia   7c40bdaeaffae708342fc773926dcfac5389348e
BuildID 20130708070214
Version 18.0

STR:

1. Open the calendar app and Click on '+' to add an event
2. In the Event screen, "All day Event?" section, click on the date field to select a date. 

Actual Result:
The text in the month field overlaps with the day field.

Expected Result:

The date values should be aligned appropriately in its corresponding text area.

Attached the screenshot

Comment 1

[(Inactive after June) George Duan [:gduan] [:喬智]]

this bug 837089 already fix this issue and it's already merged into master branch from below commit.

https://github.com/mozilla-b2g/gaia/commit/c5e0126922cde8b3bfa03d497b70fbe66bc9f8df

I checkout spin_date_picker.css and everything works fine.

Comment 3

[Leo]

Not reproducible on leo device. Removing leo flag.
Thanks.

Comment 4

[Jason Smith [:jsmith]]

(In reply to Leo from comment #3)
> Not reproducible on leo device. Removing leo flag.
> Thanks.

Please renom, do not minus in this case. The reporter should be given a chance to provide more information in this case. Also note that we need to support devices intending to support OTA from 1.01 to 1.1, so leo isn't the only device involved here.

This is reproducible on unagi on a 7/8 build. I cannot reproduce this on a 7/1 leo build however.

Comment 5

[Jason Smith [:jsmith]]

Swaroopa - Can you clarify what device you tested this on?

Comment 6

[Jason Smith [:jsmith]]

(In reply to Jason Smith [:jsmith] from comment #5)
> Swaroopa - Can you clarify what device you tested this on?

Actually, disregard. The bug as filed here was targeted for leo.

comment 3 actually seems off. The dupe of this bug was filed against leo as well. So there's two confirmed reproductions on a leo device.

Comment 7

[hyuna.cho]

It's reproduce in leo device.
Please mark in leo+

Comment 8

[Wayne Chang [:wchang]]

Leo+ per comment 7.

Comment 9

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to v1-train

Fix for v1-train.

Comment 10

[Etienne Segonzac (:etienne)]

Comment on attachment 773199 [details]
PR to v1-train

Hey Ismael, I think you're a better reviewer for this patch but feel free to redirect it back to me if you don't have the bandwidth.

Comment 11

[Ismael Gonzalez [:basiclines]]

Why don't we nominate to leo+ #837089?
That should fix this issue instead of creating patches directly on v1-train that will be miss-aligned from master changes.
Anyway if uplifting the bug doesn't not fix at all the problem we can create a new patch based on that uplift.

Comment 12

[hyuna.cho]

The bug doesn't fix with the patch on leo device. Please check the patch based on v1-train.

Comment 13

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: Merge 837089 to v1-train and add small fix

This patch has merged 837089 into v1-train and add some fix for time picker.

Comment 14

[Allen Maxwell]

Firefox OS link in settings/device info/your privacy does not work.
Works on first attempt, but second attempt fails.

Leo v1.1.0 Commercial
Build ID: 20130712070210
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/282b5c37cf8d
Gaia: e2ef782119b7e79fc62c48d36f0c36909d982988
Platform Version: 18.1
RIL Version: 01.01.00.019.158

Comment 15

[Allen Maxwell]

(In reply to Allen Maxwell from comment #14)
> Firefox OS link in settings/device info/your privacy does not work.
> Works on first attempt, but second attempt fails.
> 
> Leo v1.1.0 Commercial
> Build ID: 20130712070210
> Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/282b5c37cf8d
> Gaia: e2ef782119b7e79fc62c48d36f0c36909d982988
> Platform Version: 18.1
> RIL Version: 01.01.00.019.158

disregard comment 14

Comment 16

[Ismael Gonzalez [:basiclines]]

Comment on attachment 774695 [details]
Merge 837089 to v1-train and add small fix

The patch works perfectly on Unagi device (expected to work in the same way in any 320x480 device).
I'll give you the r+ now but plx fix the issues addressed in GH.

Thx for your hard work!

BTW: i've seen you've uplifted pavel bug on the same PR, plx update that bug commenting on wich branchs has been uplifted.

Comment 17

[(Inactive after June) George Duan [:gduan] [:喬智]]

Thanks Ismael.
Issues fixed and merge into v1.1hd.

v1.1hd: https://github.com/mozilla-b2g/gaia/commit/638e9af43dea44c9dbccd4fef02933347d7c2ab7

Comment 18

[(Inactive after June) George Duan [:gduan] [:喬智]]

Sorry ... please igonre comment 17

v1-train: https://github.com/mozilla-b2g/gaia/commit/638e9af43dea44c9dbccd4fef02933347d7c2ab7

Comment 19

[sbogati]

Issue No longer repros in the Leo
Build ID: 20130716070204
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/629020cf576b
Gaia: fb9362d34260771d4a00b9a0e10a6bbad397bd3b
Platform Version: 18.1
calendar,In the date picker of the calendar app, the text in the Month field no longer overlaps with the day.

Comment 20

[John Ford [:jhford] CET/CEST Berlin Time]

v1.1.0hd: 638e9af43dea44c9dbccd4fef02933347d7c2ab7
v1.1.0hd: f717a86a4dfdd5572b0d5ac533ad2947e2941103

Comment 21

[Ismael Gonzalez [:basiclines]]

Comment on attachment 773199 [details]
PR to v1-train

I'll remove this r? request as the other patch it already has my r+