891181 - Textbox-based <setting> bindings un-focus when forward slash (/) key is pressed

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[cricketts]

Attachment: This routine in a custom binding resolves this problem. I may have been a bit overzealous with event propogation functions, but it works.

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:22.0) Gecko/20100101 Firefox/22.0 (Beta/Release)
Build ID: 20130627161625

Steps to reproduce:

Created a Preferences.xul file for my extension, using the <setting> bindings to better integrate it into the browser. Then input a forward slash character (/).


Actual results:

Any time I input '/' into a textbox derived from <setting> (even custom bindings based on chrome://mozapps/content/extensions/setting.xml#setting-base) the focus moves from the textbox the user is currently typing in to the Firefox search bar.


Expected results:

Focus should remain in the textbox regardless of the printable character typed.

Comment 1

[Geoff Lankow (:darktrojan)]

Ugh, gHeader.onKeyPress is doing this.

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: patch

This should do the business. I can't think of anything else further up the event chain that it would affect.

Comment 3

[cricketts]

Hah! I was wondering if it was something to do with extensions.js. I had to look over the code in there in order to get my extension to load my preferences on certain actions from my preference (thankfully you all were wise enough to leave a global loadView() =D).

Is there a particular reason that gHeader uses the '/' character? I see from the code that it simply focuses on the search box. Is this to emulate the similar functions of the command-line UNIX programs man/less/nano, etc? To me that seems to be the only thing that makes sense. If that's the case it's not really a "feature" as much as bloat in my opinion. No sane person would equate the command-line search command available in a few UNIX applications to a GUI program. That is, unless it was just a handy macro used by the developers during developement that just didn't get removed.

Anyway, keep up the good work Geoff!

Comment 4

[Geoff Lankow (:darktrojan)]

Slash has been associated with find at Mozilla since ancient times. It works on webpages too.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f56958fbcc5b

Comment 6

[Mihai Morar, (:MihaiMorar)]

Marking as [qa-] based on Comment 5

> in-testsuite+

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f56958fbcc5b