Closed Bug 891210 Opened 7 years ago Closed 7 years ago

[Bluetooth][OPP cleanup] Move file-transfer related static variables into class BluetoothOppManager

Categories

(Firefox OS Graveyard :: Bluetooth, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ben.tian, Assigned: ben.tian)

References

Details

(Whiteboard: [fixed-in-birch])

Attachments

(2 files)

- Move file-transfer related static variables into class BluetoothOppManager.
- Reply error to unsupported and unrecognized server commands.
- Move file-transfer related static variables into class BluetoothOppManager.
- Reply error to unsupported and unrecognized server commands.
  ("BadRequest" to unsupported commands, and "NotImplemented" to unrecognized commands [1].)

[1] Section 10.4.8 "Miscellaneous Tests", IrOBEX 1.2
(Required) Invalid opcode test: Demonstrate that an unknown or user-defined operation request receives a “Not Implemented” (0xD1) response code from the server.
Attachment #775408 - Flags: review?(echou)
Comment on attachment 775408 [details] [diff] [review]
Patch 1: v1: change static variables to member ones

Review of attachment 775408 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Please check in with nits addressed. Thanks.

::: dom/bluetooth/BluetoothOppManager.cpp
@@ +510,5 @@
>    }
>  
>    nsCOMPtr<nsIFile> f;
>    mDsFile->mFile->Clone(getter_AddRefs(f));
>    

not-even-a-nit: please assist with removing the extra blank.

::: dom/bluetooth/BluetoothOppManager.h
@@ +198,5 @@
> +   * Currently Bluetooth*Manager inherits mozilla::ipc::UnixSocketConsumer,
> +   * which means that each Bluetooth*Manager can handle only one socket
> +   * connection at a time. We need to support concurrent multiple socket
> +   * connections, and then we will be able to have multiple file transferring
> +   * sessions at a time.

Actually, the comment above is outdated. Although Bug 806749 hasn't been fixed, Bluetooth*Manager no longer inherits mozilla::ipc::UnixSocketConsumer. In addition, I realize that concurrent file-saring seems not be neccesary if we can correctly queue file-sharing request sent from the user.

I'm going to close bug 806749 as 'resolved/won't fix', so that we can remove the comment.
Attachment #775408 - Flags: review?(echou) → review+
https://hg.mozilla.org/mozilla-central/rev/e86ca7a31c70
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.