Closed
Bug 891244
Opened 12 years ago
Closed 9 years ago
evutil_rand.c:62:2: error: void function 'ev_arc4random_buf' should not return a value [-Wreturn-type] when using clang
Categories
(Core :: IPC, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 1281596
People
(Reporter: m_kato, Assigned: m_kato)
Details
Attachments
(1 file)
977 bytes,
patch
|
bent.mozilla
:
review-
|
Details | Diff | Splinter Review |
When using clang 3.2 in Android NDK r8e, the following error occurs.
/home/makoto/Development/hg.mozilla.org/mobile-clang/ipc/chromium/src/third_party/libevent/evutil_rand.c:62:2: error: void function 'ev_arc4random_buf' should not return a value [-Wreturn-type]
return arc4random_buf(buf, n);
^ ~~~~~~~~~~~~~~~~~~~~~~
1 warning and 1 error generated.
make[1]: *** [evutil_rand.o] Error 1
Assignee | ||
Comment 1•12 years ago
|
||
Assignee | ||
Updated•12 years ago
|
Attachment #772515 -
Flags: review?(bent.mozilla)
Comment on attachment 772515 [details] [diff] [review]
fix
Thanks for the patch, but any fix to libevent should be pushed to them upstream and then we can pull from them.
Attachment #772515 -
Flags: review?(bent.mozilla)
Comment on attachment 772515 [details] [diff] [review]
fix
Review of attachment 772515 [details] [diff] [review]:
-----------------------------------------------------------------
Actually, sorry, since this is just a build fix, I think it's fine to patch locally while we wait for this patch to work its way through libevent's patch process. Just please make sure you follow through with it otherwise this bug will reappear once we pull a new version.
However:
::: ipc/chromium/src/third_party/libevent/evutil_rand.c
@@ +58,5 @@
> static void
> ev_arc4random_buf(void *buf, size_t n)
> {
> #if defined(_EVENT_HAVE_ARC4RANDOM_BUF) && !defined(__APPLE__)
> + arc4random_buf(buf, n);
You're no longer doing an early return here.
Attachment #772515 -
Flags: review-
Assignee | ||
Comment 4•12 years ago
|
||
pull request for libevent
https://github.com/libevent/libevent/pull/69
Assignee | ||
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•