891259 - [Battery] battery.chargingTime and battery.dischargingTime do no work.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Askeing Yen[:askeing][:fyen]]

Device:
  Unagi - master/v1-train
  Leo - partner v1.1.0 build
  Nexus4 - master

The WebAPI "navigator.battery.chargingTime" and "navigator.battery.dischargingTime" do not work.
They always return None.

Comment 1

[Askeing Yen[:askeing][:fyen]]

Log:
>>> var keys = []; var bat = navigator.battery; for(var key in bat){ keys.push(key); }; return keys;
[u'charging', u'chargingTime', u'dischargingTime', u'level', u'onchargingchange', u'onchargingtimechange', u'ondischargingtimechange', u'onlevelchange', u'addEventListener', u'removeEventListener', u'dispatchEvent']
>>> return navigator.battery.level
0.99
>>> return navigator.battery.charging
True
>>> return navigator.battery.chargingTime
None
>>> return navigator.battery.dischargingTime
None

Comment 2

[Thomas Zimmermann [:tzimmermann] [:tdz]]

That's because the operating system's interfaces do not provide this information. I think there have been ideas about computing an estimated charging time from discrete charge values.

Comment 3

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

> That's because the operating system's interfaces do not provide this
> information. I think there have been ideas about computing an estimated
> charging time from discrete charge values.

None still isn't correct in that situation per W3C spec:

http://www.w3.org/TR/battery-status/

"The chargingTime attribute must be set to [...] positive Infinity if if the battery is discharging, the implementation is unable to report the remaining charging time, or otherwise"

"The dischargingTime attribute must be set to the value positive Infinity, if the battery is charging,the implementation is unable to report the remaining discharging time [...] or otherwise"

So in this case, both should be Infinity because they're unable to report.

I just hit another version of this problem with an older Unagi build: 

When on the charger, chargingTime is 0 and dischargingTime is Infinity. When off the charger, chargingTime is Infinity and dischargingTime is 0. The 0s aren't correct there, in my case, and both values should remain Infinity there as well.

Comment 4

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

There's also a later editor's draft here:

https://dvcs.w3.org/hg/dap/raw-file/tip/battery/Overview.html

Same behavior applies.

Comment 5

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

I just tried this on a more recent Unagi engineering build. (20130709132728)

These results are more current than comment 3's.

chargingTime is 0 when the battery is fully charged on the charger; Infinity when it is not fully charged and on the charger; and Infinity when it is discharging.

These values are correct per-spec, assuming that it can't calculate remaining time.

dischargingTime is 0 when discharging, and Infinity when on the charger.

The 0 is incorrect; it should be Infinity if it can't calculate discharging time while discharging.

Comment 6

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [01] Bug 891259: Set discharging time to 'Infinity'

I see. This patch fixes the the internal logic of the battery backend.

Comment 7

[Mounir Lamouri (:mounir)]

Comment on attachment 773167 [details] [diff] [review]
[01] Bug 891259: Set discharging time to 'Infinity'

Review of attachment 773167 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Thomas :)

Comment 8

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Thanks a lot!

https://hg.mozilla.org/projects/birch/rev/760459ccbc30

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/760459ccbc30