Closed
Bug 891266
Opened 8 years ago
Closed 8 years ago
Allow to enable faulty.lib debug log at runtime
Categories
(Core :: mozglue, defect)
Tracking
()
RESOLVED
FIXED
mozilla25
People
(Reporter: glandium, Assigned: glandium)
Details
Attachments
(1 file)
3.69 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
When there are issues with the linker, it is useful to get a full debug log, but that is currently hidden behind a build time define and it's not very convenient. Hopefully, this shouldn't add much overhead.
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #772547 -
Flags: review?(nfroyd)
![]() |
||
Comment 2•8 years ago
|
||
Comment on attachment 772547 [details] [diff] [review] Allow to enable faulty.lib debug log at runtime Review of attachment 772547 [details] [diff] [review]: ----------------------------------------------------------------- Works for me. ::: mozglue/linker/Logging.h @@ +60,5 @@ > +}; > + > +#define DEBUG_LOG(...) \ > + do { \ > + if (Logging::isVerbose()) { \ You could use MOZ_UNLIKELY here if you wanted to squeeze out the last drop of performance.
Attachment #772547 -
Flags: review?(nfroyd) → review+
Assignee | ||
Comment 3•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/00d92898ea01
Comment 4•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/00d92898ea01
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in
before you can comment on or make changes to this bug.
Description
•