Closed Bug 891271 Opened 8 years ago Closed 8 years ago
Remove some redundant methods from ns
IImport Field Map
Found this whilst cleaning out my patch queue, I think I was looking at removing nsImportFieldMap's use of nsVoidArray, and discovered these unused functions at the same time. Nothing uses them, so we can just nuke them.
Comment on attachment 772548 [details] [diff] [review] The fix Indeed, they seem to be l10n-fragile, so not very useful. >- int32_t i = FindFieldNum(fieldDesc); I couldn't spot any remaining callers to FindFieldNum so that could go too.
Attachment #772548 - Flags: superreview?(neil) → superreview+
Comment on attachment 772548 [details] [diff] [review] The fix I can't claim to be very familiar with the import code, but could not find these in use either in comm-central or in AMO addons (using https://mxr.mozilla.org/addons/) so the deletion seems fine to me.
Attachment #772548 - Flags: review?(kent) → review+
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 25.0
You need to log in before you can comment on or make changes to this bug.