891271 - Remove some redundant methods from nsIImportFieldMap

Status: RESOLVED FIXED

(MailNews Core :: Import, defect)

Description

[Mark Banner (:standard8)]

Attachment: The fix

Found this whilst cleaning out my patch queue, I think I was looking at removing nsImportFieldMap's use of nsVoidArray, and discovered these unused functions at the same time.

Nothing uses them, so we can just nuke them.

Comment 1

[[e-mail]]

Comment on attachment 772548 [details] [diff] [review]
The fix

Indeed, they seem to be l10n-fragile, so not very useful.

>-  int32_t i = FindFieldNum(fieldDesc);
I couldn't spot any remaining callers to FindFieldNum so that could go too.

Comment 2

[Kent James (:rkent)]

Comment on attachment 772548 [details] [diff] [review]
The fix

I can't claim to be very familiar with the import code, but could not find these in use either in comm-central or in AMO addons (using https://mxr.mozilla.org/addons/) so the deletion seems fine to me.

Comment 3

[Mark Banner (:standard8)]

https://hg.mozilla.org/comm-central/rev/3d5562a963ce