891341 - wiki.mozilla.org confirmation email for changing email is sent from a bogus domain name

Status: VERIFIED FIXED

(Infrastructure & Operations :: IT-Managed Tools, task)

Description

[Karl Dubost💡 :karlcow]

Context:

Go to a user profile, change your email address. The server requires you to confirm your new email address by sending an email address. It is necessary to be able to edit the wiki. 

The result:
The mail doesn't reach my mailbox at all.

Details: 

I went through my email server logs. The wiki server domain name for email doesn't exist. See what my server is replying.

nerval sendmail[55347]: NOQUEUE: connect from mx2.corp.phx1.mozilla.com [63.245.216.70]
nerval sendmail[55347]: r68HXxdC055347: ruleset=check_mail, arg1=<[e-mail]>, relay=mx2.corp.phx1.mozilla.com [63.245.216.70], reject=553 5.1.8 <[e-mail]>... Domain of sender address [e-mail] does not exist
nerval sendmail[55347]: r68HXxdC055347: from=<[e-mail]>, size=1392, class=0, nrcpts=0, bodytype=8BITMIME, proto=ESMTP, daemon=MTA, relay=mx2.corp.phx1.mozilla.com [63.245.216.70]

Comment 1

[Alison Wheeler [:AlisonW]]

Sender is set in the LocalSettings.php file, entry for "$wgPasswordSender". My copy of that file has been partially redacted (which is fine) and shows "[e-mail]" as the value. I'm hoping it isn't!

Comment 2

[Ed Lim [:limed]]

(In reply to Alison Wheeler [:AlisonW] from comment #1)
> Sender is set in the LocalSettings.php file, entry for "$wgPasswordSender".
> My copy of that file has been partially redacted (which is fine) and shows
> "[e-mail]" as the value. I'm hoping it isn't!

This is actually already set. But I've been digging around the media wiki docs and noticed this option

http://www.mediawiki.org/wiki/Manual:$wgAdditionalMailParams

"Additional email parameters, will be passed as the last argument to mail() PHP function call."

Based on http://php.net/manual/en/function.mail.php

We can pass '-f [e-mail]' to that config option to set the envelope sender.

Comment 3

[Ed Lim [:limed]]

Over to webops to implement

Comment 4

[Chris Turra [:cturra]]

i have pushed the suggestion :limed made above to stage. will do testing on it and confirm if it results in the experience we expect.

Comment 5

[Chris Turra [:cturra]]

i added the following...

 $wgAdditionalMailParams = "-f [e-mail]";


which added the below header to the "change email" message:

  Return-Path: <[e-mail]>


Karl, would you be able to test in stage (wiki.allizom.org) and confirm this functions as you expect?

Comment 6

[Karl Dubost💡 :karlcow]

Alleluia, it is working and I have received the confirmation email.

Jul  9 14:42:50 nerval sendmail[80355]: NOQUEUE: connect from mx2.corp.phx1.mozilla.com [63.245.216.70]
Jul  9 14:42:50 nerval sendmail[80355]: r69Igoee080355: from=<[e-mail]>, size=1467, class=0, nrcpts=1, msgid=<[e-mail]>, bodytype=8BITMIME, proto=ESMTP, daemon=MTA, relay=mx2.corp.phx1.mozilla.com [63.245.216.70]
Jul  9 14:42:50 nerval sendmail[80358]: r69Igoee080355: alias <karl*****@******.***> => ********

Comment 7

[Chris Turra [:cturra]]

thnx for the update Karl! i have pushed this same change to production and have tested it with my account. feel free to run a test there yourself and mark this bug as verified.

Comment 8

[Karl Dubost💡 :karlcow]

Chris, 

This is working in production!. 
Excellent.