Closed
Bug 891361
Opened 11 years ago
Closed 11 years ago
Return empty array for searches on undefined users
Categories
(Webmaker Graveyard :: MakeAPI, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: daleee, Assigned: daleee)
Details
Attachments
(1 file)
eg: https://webmaker.org/search?type=user&q=fixme
Should render a nice error page!
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → dale
|
||
Updated•11 years ago
|
Component: webmaker.org → MakeAPI
Summary: Gracefully handle error responses from MakeAPI → Return empty array for searches on undefined users
|
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #772723 -
Flags: review?(chris)
|
|
||
Comment 2•11 years ago
|
||
Comment on attachment 772723 [details] [review]
https://github.com/mozilla/MakeAPI/pull/106
Code r+
I'm currently unable to test because my laptop got bricked and I'm setting up a new dev environment.
matt: can you test please?
Attachment #772723 -
Flags: review?(schranz.m)
Attachment #772723 -
Flags: review?(chris)
Attachment #772723 -
Flags: review+
|
||
Comment 3•11 years ago
|
||
Attachment #772723 -
Flags: review?(schranz.m) → review+
|
||
Comment 4•11 years ago
|
||
Commits pushed to master at https://github.com/mozilla/MakeAPI
https://github.com/mozilla/MakeAPI/commit/95c50e1794f19a0017a970984cb3d8e145f9b516
[bug 891361] Return empty result set on undefined users
https://github.com/mozilla/MakeAPI/commit/224fb222bea8023d3f1802efa061f7a1e2c01aa5
Merge pull request #106 from daleee/891361-return-empty-array-on-undefined-users
[bug 891361] Return empty result set on undefined users
|
|
Assignee | |
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in
before you can comment on or make changes to this bug.
Description
•