eg: https://webmaker.org/search?type=user&q=fixme Should render a nice error page!
Component: webmaker.org → MakeAPI
Summary: Gracefully handle error responses from MakeAPI → Return empty array for searches on undefined users
Comment on attachment 772723 [details] [review] https://github.com/mozilla/MakeAPI/pull/106 Code r+ I'm currently unable to test because my laptop got bricked and I'm setting up a new dev environment. matt: can you test please?
Comment on attachment 772723 [details] [review] https://github.com/mozilla/MakeAPI/pull/106 Works.
Attachment #772723 - Flags: review?(schranz.m) → review+
Commits pushed to master at https://github.com/mozilla/MakeAPI https://github.com/mozilla/MakeAPI/commit/95c50e1794f19a0017a970984cb3d8e145f9b516 [bug 891361] Return empty result set on undefined users https://github.com/mozilla/MakeAPI/commit/224fb222bea8023d3f1802efa061f7a1e2c01aa5 Merge pull request #106 from daleee/891361-return-empty-array-on-undefined-users [bug 891361] Return empty result set on undefined users
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.