891371 - Add image to contact is blank in the crop screen

Status: RESOLVED DUPLICATE of bug 891294

(Firefox OS Graveyard :: Gaia::Gallery, defect)

Description

[Florin Strugariu [:Bebe]]

STR:

1. Create a contact if no contacts are available
2. Click on the "+" to add an image to the contact.
3. Select "Gallery" to assign an image from the gallery.
4. Crop the image and tap OK

Expected:
4. The image is available and can be cropped
Tapping OK advances to the next step

Actual:
4. The image is not available and can't be cropped


This is reproducible on master:
Gecko  http://hg.mozilla.org/mozilla-central/rev/f2de2035f0af
Gaia  45cbc4652be9a05d5f981cfa9d69b954d2192efd
BuildID 20130709030202
Version 25.0a1

Comment 1

[Florin Strugariu [:Bebe]]

Also tapping on the OK button has no effect

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

Hi folks,

I guess this shouldn't fall under the contacts component, since we are calling a web activity and letting the gallery handling this.

My question is, the problem is happening when we return back to the contacts app, or is happening in the gallery meanwhile we try to crop the image?

Thanks!
F.

Comment 3

[Florin Strugariu [:Bebe]]

Logcat:

E/GeckoConsole( 2019): [JavaScript Warning: "Error: WebGL: Exceeded 2 live WebGL contexts for this principal, losing the least recently used one." {file: "app://gallery.gaiamobile.org/js/ImageEditor.js" line: 1130}]
I/Gecko   ( 2019): SharedSurface_Gralloc::Create -------
D/memalloc( 1806):  Out of PMEM. Dumping PMEM stats for debugging
D/memalloc( 1806):  ------------- PRINT PMEM STATS --------------
D/memalloc( 1806):  Node 0 -> Start Address : 0 Size 19200 Free info 0
D/memalloc( 1806):  Node 1 -> Start Address : 19200 Size 19200 Free info 0
D/memalloc( 1806):  Node 2 -> Start Address : 38400 Size 19200 Free info 0
D/memalloc( 1806):  Node 3 -> Start Address : 57600 Size 14080 Free info 1
D/memalloc( 1806):  Node 4 -> Start Address : 71680 Size 2560 Free info 0
D/memalloc( 1806):  Node 5 -> Start Address : 74240 Size 2560 Free info 0
D/memalloc( 1806):  Node 6 -> Start Address : 76800 Size 19200 Free info 0
D/memalloc( 1806):  Node 7 -> Start Address : 96000 Size 19200 Free info 0
D/memalloc( 1806):  Node 8 -> Start Address : 115200 Size 1024 Free info 0
D/memalloc( 1806):  Node 9 -> Start Address : 116224 Size 1024 Free info 0
D/memalloc( 1806):  Node 10 -> Start Address : 117248 Size 16640 Free info 0
D/memalloc( 1806):  Node 11 -> Start Address : 133888 Size 16640 Free info 0
D/memalloc( 1806):  Node 12 -> Start Address : 150528 Size 2560 Free info 0
D/memalloc( 1806):  Node 13 -> Start Address : 153088 Size 2560 Free info 0
D/memalloc( 1806):  Node 14 -> Start Address : 155648 Size 19200 Free info 0
D/memalloc( 1806):  Node 15 -> Start Address : 174848 Size 16640 Free info 0
D/memalloc( 1806):  Node 16 -> Start Address : 191488 Size 16640 Free info 0
D/memalloc( 1806):  Node 17 -> Start Address : 208128 Size 19200 Free info 0
D/memalloc( 1806):  Node 18 -> Start Address : 227328 Size 19200 Free info 0
D/memalloc( 1806):  Node 19 -> Start Address : 246528 Size 15616 Free info 1
D/memalloc( 1806):  Total Allocated: Total Free: 
D/memalloc( 1806): ----------------------------------------------
E/memalloc( 1806): /dev/pmem: No more pmem available
W/memalloc( 1806): Falling back to ashmem
D/memalloc( 1806): ashmem: Allocated buffer base:0x4a282000 size:532480 fd:170
D/memalloc( 2019): ashmem: Mapped buffer base:0x4565a000 size:532480 fd:47
I/Gecko   ( 2019): SharedSurface_Gralloc::Create: success -- surface 0x43ceb240, GraphicBuffer 0x45724780.
E/GeckoConsole( 2019): [JavaScript Error: "Error: Error compiling vertex shader:ERROR: 0:1: 'undefined' : syntax error 
E/GeckoConsole( 2019): " {file: "app://gallery.gaiamobile.org/js/ImageEditor.js" line: 1138}]
I/Gecko   ( 2019): SharedSurface_Gralloc::Create -------
D/memalloc( 1806):  Out of PMEM. Dumping PMEM stats for debugging
D/memalloc( 1806):  ------------- PRINT PMEM STATS --------------
D/memalloc( 1806):  Node 0 -> Start Address : 0 Size 19200 Free info 0
D/memalloc( 1806):  Node 1 -> Start Address : 19200 Size 19200 Free info 0
D/memalloc( 1806):  Node 2 -> Start Address : 38400 Size 19200 Free info 0
D/memalloc( 1806):  Node 3 -> Start Address : 57600 Size 14080 Free info 1
D/memalloc( 1806):  Node 4 -> Start Address : 71680 Size 2560 Free info 0
D/memalloc( 1806):  Node 5 -> Start Address : 74240 Size 2560 Free info 0
D/memalloc( 1806):  Node 6 -> Start Address : 76800 Size 19200 Free info 0
D/memalloc( 1806):  Node 7 -> Start Address : 96000 Size 19200 Free info 0
D/memalloc( 1806):  Node 8 -> Start Address : 115200 Size 1024 Free info 0
D/memalloc( 1806):  Node 9 -> Start Address : 116224 Size 1024 Free info 0
D/memalloc( 1806):  Node 10 -> Start Address : 117248 Size 16640 Free info 0
D/memalloc( 1806):  Node 11 -> Start Address : 133888 Size 16640 Free info 0
D/memalloc( 1806):  Node 12 -> Start Address : 150528 Size 2560 Free info 0
D/memalloc( 1806):  Node 13 -> Start Address : 153088 Size 2560 Free info 0
D/memalloc( 1806):  Node 14 -> Start Address : 155648 Size 19200 Free info 0
D/memalloc( 1806):  Node 15 -> Start Address : 174848 Size 16640 Free info 0
D/memalloc( 1806):  Node 16 -> Start Address : 191488 Size 16640 Free info 0
D/memalloc( 1806):  Node 17 -> Start Address : 208128 Size 19200 Free info 0
D/memalloc( 1806):  Node 18 -> Start Address : 227328 Size 19200 Free info 0
D/memalloc( 1806):  Node 19 -> Start Address : 246528 Size 15616 Free info 1
D/memalloc( 1806):  Total Allocated: Total Free: 
D/memalloc( 1806): ----------------------------------------------
E/memalloc( 1806): /dev/pmem: No more pmem available
W/memalloc( 1806): Falling back to ashmem
D/memalloc( 1806): ashmem: Allocated buffer base:0x4ad00000 size:532480 fd:174
D/memalloc( 2019): ashmem: Mapped buffer base:0x45982000 size:532480 fd:50
I/Gecko   ( 2019): SharedSurface_Gralloc::Create: success -- surface 0x43ceb140, GraphicBuffer 0x45724680.
I/Gecko   ( 2019): [SharedSurface_Gralloc 0x4379ab40] destroyed
D/memalloc( 2019): ashmem: Unmapping buffer base: 0x44300000 size: 532480
I/Gecko   ( 2019): [SharedSurface_Gralloc 0x4379abc0] destroyed
D/memalloc( 2019): ashmem: Unmapping buffer base: 0x45c00000 size: 532480
D/memalloc( 1806): ashmem: Freeing buffer base:0x46b00000 size:532480 fd:179
D/memalloc( 1806): ashmem: Unmapping buffer base: 0x46b00000 size: 532480
D/memalloc( 1806): ashmem: Freeing buffer base:0x47300000 size:532480 fd:182
D/memalloc( 1806): ashmem: Unmapping buffer base: 0x47300000 size: 532480
E/GeckoConsole( 2019): [JavaScript Error: "TypeError: cropEditor is undefined" {file: "app://gallery.gaiamobile.org/gaia_build_defer_index.js" line: 425}]
E/GeckoConsole( 2019): [JavaScript Error: "TypeError: cropEditor is undefined" {file: "app://gallery.gaiamobile.org/gaia_build_defer_index.js" line: 425}]

Comment 4

[Florin Strugariu [:Bebe]]

(In reply to Francisco Jordano [:arcturus] from comment #2)
> Hi folks,
> 
> I guess this shouldn't fall under the contacts component, since we are
> calling a web activity and letting the gallery handling this.
> 
> My question is, the problem is happening when we return back to the contacts
> app, or is happening in the gallery meanwhile we try to crop the image?
> 
> Thanks!
> F.

In the gallery meanwhile we try to crop the image

So I think you are right it's a gallery bug

Thanks for pointing this in the right direction F.

Comment 5

[Ben Kelly [:bkelly, not reviewing]]

(In reply to Florin Strugariu [:Bebe] from comment #3)
> E/GeckoConsole( 2019): [JavaScript Error: "TypeError: cropEditor is
> undefined" {file: "app://gallery.gaiamobile.org/gaia_build_defer_index.js"
> line: 425}]
> E/GeckoConsole( 2019): [JavaScript Error: "TypeError: cropEditor is
> undefined" {file: "app://gallery.gaiamobile.org/gaia_build_defer_index.js"
> line: 425}]

Just a guess, but maybe cropEditor should be checked for null here?

  https://github.com/mozilla-b2g/gaia/blob/master/apps/gallery/js/gallery.js#L788

Comment 6

[John Hu [:johnhu][:johu][:醬糊小弟]]

Yes, it is a regression bug since bug 847908 is merged to master. That happened at July 7th. 

It's not the cropEditor's problem. It is the initialization of ImageEditor is failed. So the cropEditor will always be undefined.

There is a bug already dealing with it, bug 891294.

Mark this bug as duplicate of bug 891294