89139 - nsNSSComponent::RegisterProfileChangeObserver() returns garbage

Status: VERIFIED FIXED

(Core Graveyard :: Security: UI, defect, P2)

Description

[Mike Pinkerton (not reading bugmail)]

nsNSSComponent::RegisterProfileChangeObserver() returns a result from an 
uninitialized variable:

nsresult
nsNSSComponent::RegisterProfileChangeObserver()
{
  nsresult rv;
  
  nsCOMPtr<nsIObserverService> 
observerService(do_GetService(NS_OBSERVERSERVICE_CONTRACTID));
  NS_ASSERTION(observerService, "could not get observer service");
  if (observerService) {
    observerService->AddObserver(this, PROFILE_BEFORE_CHANGE_TOPIC);
    observerService->AddObserver(this, PROFILE_AFTER_CHANGE_TOPIC);
  }
  return rv;
}

|rv| is never given a value. this is a compiler warning on mac, but can have 
serious side effects if someone is checking this return value.

Comment 1

[John Unruh]

PSM

Comment 2

[Stephane Saux]

setting nsbranch.  This looks like something that's easy to fix.
t-> 2.0

Comment 3

[David P. Drinan]

Attachment: Patch for review.

Comment 4

[Stephen Walker]

r=walk84

Comment 5

[Christopher Blizzard (:blizzard)]

sr=blizzard

Comment 6

[David P. Drinan]

Fix checked into trunk.

Comment 7

[John Unruh]

Marking fixed per ddrinan's comment. How can this be verified?

Comment 8

[Stephane Saux]

returning a known value is clearly better than returning an uninitialized value.
Can we get PDT+ on this one?

Comment 9

[Stephane Saux]

PDT+ as per 07/09/2001 PDT meeting.

Comment 10

[Stephane Saux]

verified checked in the branch. v1.44.4.1
There is no known problem to verify this against.
-> verified.

Comment 11

[Stephen Walker]

*** Bug 83264 has been marked as a duplicate of this bug. ***