Closed
Bug 891400
Opened 11 years ago
Closed 11 years ago
IonMonkey: Pattern match better on static typed array indexes
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla25
People
(Reporter: bhackett1024, Unassigned)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
1.25 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
Bug 864214 added pattern matching so that static typed array accesses can be generated, but the pattern matching done on the typed array index does not capture all cases. Namely, no shift is needed if the array has an element width of one, and accesses at constant indexes are not handled. This was causing 30% of typed array accesses in asm.js-zlib to use the generic path, which are fixed by this patch.
Attachment #772687 -
Flags: review?(jdemooij)
|
||
Updated•11 years ago
|
Attachment #772687 -
Flags: review?(jdemooij) → review+
|
Reporter | |
Comment 1•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/0670cdaf7e9c
|
|
Reporter | |
Comment 2•11 years ago
|
||
Followup fix. This exposed a preexisting issue where LoadTypedArrayElementStatic never does bounds checks when loading from uint32 arrays. https://hg.mozilla.org/integration/mozilla-inbound/rev/16e818a58357
|
||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/0670cdaf7e9c https://hg.mozilla.org/mozilla-central/rev/16e818a58357
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in
before you can comment on or make changes to this bug.
Description
•