891412 - Give admin users the ability to edit the event organizer username and email

Status: RESOLVED FIXED

(Webmaker Graveyard :: Events, defect)

Description

[hivelearningnyc]

I've entered numerous events on behalf of many hosts. When I enter it it puts the persona I used down as host. One of the actual hosts wants to change it to show that they are hosting. Since they didn't enter the event they can not edit it at all. I attempted to log in with the same account but noticed that field was something I couldn't edit. Would it be possible to make this an editable field?

Comment 1

[Amira]

+Brett

Is this somewhere on a radar to get completed? We upload a lot of events for people because of glitches, bulk events and other stuff and it would be great to switch over the users instead of it always being MozTeach -- the map pretty much looks like all events are uploaded by MozTeach.

Comment 2

[Barry Tulchinsky [:btulchinsky]]

I'm currently looking into this and initially thought this was initially server side. Now that I actually was able to get the local login working for webmaker and see how it actually works, there is some client side work to do as well. I have a couple of questions:

a) In what matter/behaviour are the users going to pick a new organizer/host, ie. drop down list, google instant, etc.?

b) We currently only have the event object available in the details view, we would also need to pass a variable to allow that field to be editable and also an array of allowable users to switch to, is this acceptable? 

Hopefully I'm not over-complicating things.

Comment 3

[hivelearningnyc]

I'm not sure how anyone envisioned it would work. The idea came from the fact that I was inputting events on behalf of individuals who were unable to or were having issues submitting. As I inputted, it auto assigned whatever account I was under as the host.

Comment 4

[Barry Tulchinsky [:btulchinsky]]

Attachment: bug891412 pull request

Comment 5

[David Humphrey (:humph)]

Comment on attachment 821211 [details] [review]
bug891412 pull request

I've done a pass at this, but it really needs Chris and Kate to sign off on it.  Adding them for additional reviews.

Please fix my issues in the meantime.

Comment 6

[inactivate account for kate]

Comment on attachment 821211 [details] [review]
bug891412 pull request

Mostly this is good, a few fixes to the CSS (see http://jsbin.com/OdArOta/1/edit for an example) and adding gettext to your new string.

Comment 7

[Barry Tulchinsky [:btulchinsky]]

Comment on attachment 821211 [details] [review]
bug891412 pull request

updated with suggested fixes

Comment 8

[inactivate account for kate]

Please rebass and squash; also run grunt to check/fix any style errors.

Comment 9

[inactivate account for kate]

rebase*

Comment 10

[David Humphrey (:humph)]

Can we get this bug finished/landed please?  Barry/Kate?

Comment 11

[Barry Tulchinsky [:btulchinsky]]

I did the cleanup and rebase but I can't test it locally due to some account issues (I'm constantly being logged out). I'll work on trying to resolve my account problem this week, but if someone could give it a quick test that would be appreciated. But I think it should be good to go unless Kate disagrees.

Comment 12

[Ali Al Dallal [:alicoding]]

Can you try to rebase again and I would be happy to help with the test and landing this if this is still relevant.

Comment 13

[Gavin Suntop [:gvn]]

Note that the old Events platform at webmaker.org/events has been deprecated.

We have a new Events app running at events.webmaker.org.

Comment 14

[Matt Thompson (@OpenMatt :OpenMatt)]

* Question: Does the new events.webmaker.org app currently include the ability for admins to edit the "Host" field? (If so, we can mark this resolved fixed, right?)

Comment 15

[inactivate account for kate]

What is the host field? Is that the organizer's username? email?

Comment 16

[Gavin Suntop [:gvn]]

Same Q as Kate. My assumption is this ticket is no longer valid?

Comment 17

[Matt Thompson (@OpenMatt :OpenMatt)]

* (Sorry for slow reply)

* Amira: just want to make sure you have what you need here, before we mark as resolved fixed / invalid. 

* The use case we need to support: where Amira or a staff member *enters an event FOR a user*. We need those events to show up with the right organizer username. So that an admin like Amira can input the correct username. 

* Amira: is that still a requirement, and does the new events platform provide it?

Comment 18

[Amira]

Yes...we still need this. I imagine in 2014 we will still have many partners and event organizers who need to need help uploading their event. If we help we need a way to transfer it to their Webmaker username so that in the contributions it counts as different people uploading events (and not 50% from Mozteach). 

Also, this is now reliant on us actually having access to the backend for the new events platform (of which I've already filled a separate bug).

Comment 19

[Matt Thompson (@OpenMatt :OpenMatt)]

Thanks Amira. So this ticket is still valid.

* Kate / Gavin: have re-scoped this ticket accordingly. to:
"Give admin users the ability to edit the event organizer username and email"

* make sense?

Comment 20

[inactivate account for kate]

Yep, sounds good to me.

Note that there could be unexpected results if the username and email are changed to a username/email combination that either don't exist in our existing user database, or don't match

Comment 21

[Gavin Suntop [:gvn]]

Attachment: https://github.com/mozilla/webmaker-events-2/pull/78

If there's any way we can query a service to get a username from an email (or vice versa) to prevent bad pairs that'd be good. 

Otherwise, this patch should do the trick...