Closed Bug 891485 Opened 10 years ago Closed 10 years ago

[fig] NoSuchMethodError when tapping "History" or "Your tabs from last time" on 2.3

Categories

(Firefox for Android Graveyard :: General, defect, P1)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
ARM
Android
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 26

People

(Reporter: Margaret, Assigned: lucasr)

References

Details

(Whiteboard: fixed-fig)

Attachments

(1 file)

Use SimpleCursorAdapter from Android's support library
2.35 KB, patch
Margaret
: review+
Details | Diff | Splinter Review 
Ran into this crash on my Nexus S, running 2.3.6:

E/GeckoAppShell( 8768): >>> REPORTING UNCAUGHT EXCEPTION FROM THREAD 1 ("main")
E/GeckoAppShell( 8768): java.lang.NoSuchMethodError: org.mozilla.gecko.home.HistoryPage$HistoryAdapter.swapCursor
E/GeckoAppShell( 8768): 	at org.mozilla.gecko.home.HistoryPage$CursorLoaderCallbacks.onLoadFinished(HistoryPage.java:351)
E/GeckoAppShell( 8768): 	at org.mozilla.gecko.home.HistoryPage$CursorLoaderCallbacks.onLoadFinished(HistoryPage.java:342)
E/GeckoAppShell( 8768): 	at android.support.v4.app.LoaderManagerImpl$LoaderInfo.callOnLoadFinished(LoaderManager.java:427)
E/GeckoAppShell( 8768): 	at android.support.v4.app.LoaderManagerImpl$LoaderInfo.onLoadComplete(LoaderManager.java:395)
E/GeckoAppShell( 8768): 	at android.support.v4.content.Loader.deliverResult(Loader.java:103)
E/GeckoAppShell( 8768): 	at org.mozilla.gecko.home.SimpleCursorLoader.deliverResult(SimpleCursorLoader.java:76)
E/GeckoAppShell( 8768): 	at org.mozilla.gecko.home.SimpleCursorLoader.deliverResult(SimpleCursorLoader.java:31)
E/GeckoAppShell( 8768): 	at android.support.v4.content.AsyncTaskLoader.dispatchOnLoadComplete(AsyncTaskLoader.java:221)
E/GeckoAppShell( 8768): 	at android.support.v4.content.AsyncTaskLoader$LoadTask.onPostExecute(AsyncTaskLoader.java:61)
E/GeckoAppShell( 8768): 	at android.support.v4.content.ModernAsyncTask.finish(ModernAsyncTask.java:461)
E/GeckoAppShell( 8768): 	at android.support.v4.content.ModernAsyncTask.access$500(ModernAsyncTask.java:47)
E/GeckoAppShell( 8768): 	at android.support.v4.content.ModernAsyncTask$InternalHandler.handleMessage(ModernAsyncTask.java:474)
E/GeckoAppShell( 8768): 	at android.os.Handler.dispatchMessage(Handler.java:99)
E/GeckoAppShell( 8768): 	at android.os.Looper.loop(Looper.java:130)
E/GeckoAppShell( 8768): 	at android.app.ActivityThread.main(ActivityThread.java:3683)
E/GeckoAppShell( 8768): 	at java.lang.reflect.Method.invokeNative(Native Method)
E/GeckoAppShell( 8768): 	at java.lang.reflect.Method.invoke(Method.java:507)
E/GeckoAppShell( 8768): 	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:839)
E/GeckoAppShell( 8768): 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:597)
E/GeckoAppShell( 8768): 	at dalvik.system.NativeStart.main(Native Method)
Assignee: nobody → lucasr.at.mozilla
Blocks: new-about-home
Priority: -- → P1

        Attachment #772815 -
        Flags: review?(margaret.leibovic)

    
    

    
  
Comment on attachment 772815 [details] [diff] [review]
Use SimpleCursorAdapter from Android's support library

I guess this is just one of those things we should add to our mental reviewer checklists :)

        Attachment #772815 -
        Flags: review?(margaret.leibovic) → review+

    
  
Whiteboard: fixed-fig

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/c2c9842f7142
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
Product: Firefox for Android → Firefox for Android Graveyard

          You need to log in
          before you can comment on or make changes to this bug.