Closed
Bug 891545
Opened 13 years ago
Closed 13 years ago
Defect- No Context menu on right click in "Write Something" field
Categories
(Firefox Graveyard :: SocialAPI, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
Firefox 25
People
(Reporter: Samvedana, Assigned: mixedpuppy)
References
Details
Attachments
(2 files)
|
190.68 KB,
image/png
|
Details | |
|
918 bytes,
patch
|
markh
:
review+
|
Details | Diff | Splinter Review |
For Social API Share feature, When I use right click in "Write Something" field, It doesn't show Context menu as shown by Facebook.
Please see attached screenshot of Facebook which supports context menu.
I believe this is something Facebook needs to support.
Component: SocialAPI → SocialAPI: Providers
OS: Windows 8 → All
Hardware: x86_64 → All
| Assignee | ||
Comment 2•13 years ago
|
||
This is our context menu. we need to hook it up to the share iframe.
Component: SocialAPI: Providers → SocialAPI
| Assignee | ||
Comment 3•13 years ago
|
||
Assignee: nobody → mixedpuppy
Attachment #774323 -
Flags: review?(mhammond)
Comment 4•13 years ago
|
||
Comment on attachment 774323 [details] [diff] [review]
add tooltip and context menu to share panel
Review of attachment 774323 [details] [diff] [review]:
-----------------------------------------------------------------
::: browser/base/content/browser-social.js
@@ +615,5 @@
> iframe.setAttribute("flex", "1");
> panel.appendChild(iframe);
> this.populateProviderMenu();
> },
>
kill this (unrelated) trailing whitespace while you are at it :)
Attachment #774323 -
Flags: review?(mhammond) → review+
| Assignee | ||
Comment 5•13 years ago
|
||
Comment 6•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 25
Samvedana, please verify this is fixed in tomorrow's Nightly.
Keywords: verifyme
| Reporter | ||
Comment 8•13 years ago
|
||
User Agent :Mozilla/5.0 (Windows NT 6.1; rv:25.0) Gecko/20130731 Firefox/25.0
Build ID:20130731030203
WFM
Windows 7 32 bit
Tested on latest nightly, I can see menu upon right click in "write something field".
Also tested Context menu functions, they work as expected.
Status: RESOLVED → VERIFIED
Keywords: verifyme
Updated•7 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•