Closed Bug 891632 Opened 7 years ago Closed 7 years ago

Port NO_DIST_INSTALL to moz.build

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla25

People

(Reporter: gps, Assigned: gps)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

We need NO_DIST_INSTALL in moz.build before we can derecursify some build steps because NO_DIST_INSTALL effectively short-circuits a bunch of rules.

I'd like NO_DIST_INSTALL to be attached closer to the content it applies to (not file scope). But, we can deal with that later, methinks.
Many of the moved variables are likely not needed. moz.build should one
day validate the sandbox's output and error if "useless" variables are
present.
Attachment #772976 - Flags: review?(joey)
Assignee: nobody → gps
Just as I submitted this my local build found a lingering use in
dom/plugins/test/testplugin/testplugin.mk. I've corrected that in this
patch.
Attachment #772977 - Flags: review?(joey)
Attachment #772976 - Attachment is obsolete: true
Attachment #772976 - Flags: review?(joey)
Comment on attachment 772977 [details] [diff] [review]
Port NO_DIST_INSTALL to moz.build

Looks good.

Maybe word the variable description as 'file paths defined by' other variables in place of 'installed in':

+        If present, some files installed in other variables won't be
+        distributed/shipped with the produced build.
Attachment #772977 - Flags: review?(joey) → review+
http://hg.mozilla.org/integration/mozilla-inbound/rev/e6a559f42452
Status: NEW → ASSIGNED
Flags: in-testsuite+
Target Milestone: --- → mozilla25
https://hg.mozilla.org/mozilla-central/rev/e6a559f42452
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Blocks: 896797
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.