Work - NewUI - Define and implement keyboard interaction with half-height autocomplete.

RESOLVED FIXED in Firefox 27

Status

Firefox for Metro
Firefox Start
P2
normal
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jwilde, Assigned: rsilveira)

Tracking

unspecified
Firefox 27
x86_64
Windows 8
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [preview][blocked] feature=work)

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

4 years ago
Currently, we more or less retain the default keyboard behavior for an autocomplete results widget in desktop Firefox:

- Press the down arrow to jump into the autocomplete results.
- Keep pressing the down arrow to step to the next item in the autocomplete results.

Given that the autocomplete results appear above the urlbar, we should probably change up the interaction. Yuan, how should the keyboard arrow keys work with the urlbar and autocomplete?
Flags: needinfo?(ywang)

Updated

4 years ago
Component: General → Firefox Start
(Reporter)

Updated

4 years ago
Blocks: 831910

Updated

4 years ago
Whiteboard: [preview-triage]

Updated

4 years ago
Whiteboard: [preview-triage] → [preview-triage] feature=work

Updated

4 years ago
Priority: -- → P2
Whiteboard: [preview-triage] feature=work → [preview] feature=work
Whiteboard: [preview] feature=work → [preview][blocked] feature=work
Created attachment 804791 [details] [diff] [review]
Patch v1

With this patch the first press on the the up arrow key will act like the down key today, selecting the top left item in the autocomplete grid. To go to other items the user has to press down though, pressing up will put the focus back on the url edit box. Left and right will move the cursor within the textbox.

Other option would be to select the last item in the grid, which would be in the "search for" grid. This would enable to cycle through every item just with the up arrow.

I went with the former because I'd guess that "your results" will be used more often.
Assignee: nobody → rsilveira
Status: NEW → ASSIGNED
Attachment #804791 - Flags: review?(mbrubeck)
Comment on attachment 804791 [details] [diff] [review]
Patch v1

Cancelling review for now, it's acting up when "your results" is empty.
Attachment #804791 - Flags: review?(mbrubeck)
Created attachment 804811 [details] [diff] [review]
Patch v2

Working better when "your results" is empty. Part of what got me confused was actually bug 916383.

The up arrow starts at the top/left item and it cycles through just fine now.
Attachment #804791 - Attachment is obsolete: true
Attachment #804811 - Flags: review?(mbrubeck)
Attachment #804811 - Flags: review?(mbrubeck) → review+
Created attachment 806311 [details] [diff] [review]
Test

Test bug. 

Urlbar tests were aggressively closing tabs, did a small fix to make it open the tabs it was closing.
Attachment #806311 - Flags: review?(mbrubeck)
https://hg.mozilla.org/integration/fx-team/rev/008017679816

Comment 6

4 years ago
https://hg.mozilla.org/mozilla-central/rev/008017679816
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 27
Attachment #806311 - Flags: review?(mbrubeck) → review+
test
https://hg.mozilla.org/integration/fx-team/rev/c55088fba674
https://hg.mozilla.org/mozilla-central/rev/c55088fba674
Flags: in-testsuite+
(Reporter)

Updated

4 years ago
Flags: needinfo?(ywang)
Depends on: 940451
You need to log in before you can comment on or make changes to this bug.