891667 - Work - NewUI - Define and implement keyboard interaction with half-height autocomplete.

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: Firefox Start, defect, P2)

Description

[Jonathan Wilde [:jwilde]]

Currently, we more or less retain the default keyboard behavior for an autocomplete results widget in desktop Firefox:

- Press the down arrow to jump into the autocomplete results.
- Keep pressing the down arrow to step to the next item in the autocomplete results.

Given that the autocomplete results appear above the urlbar, we should probably change up the interaction. Yuan, how should the keyboard arrow keys work with the urlbar and autocomplete?

Comment 1

[Rodrigo Silveira [:rsilveira] [:rodms]]

Attachment: Patch v1

With this patch the first press on the the up arrow key will act like the down key today, selecting the top left item in the autocomplete grid. To go to other items the user has to press down though, pressing up will put the focus back on the url edit box. Left and right will move the cursor within the textbox.

Other option would be to select the last item in the grid, which would be in the "search for" grid. This would enable to cycle through every item just with the up arrow.

I went with the former because I'd guess that "your results" will be used more often.

Comment 2

[Rodrigo Silveira [:rsilveira] [:rodms]]

Comment on attachment 804791 [details] [diff] [review]
Patch v1

Cancelling review for now, it's acting up when "your results" is empty.

Comment 3

[Rodrigo Silveira [:rsilveira] [:rodms]]

Attachment: Patch v2

Working better when "your results" is empty. Part of what got me confused was actually bug 916383.

The up arrow starts at the top/left item and it cycles through just fine now.

Comment 4

[Rodrigo Silveira [:rsilveira] [:rodms]]

Attachment: Test

Test bug. 

Urlbar tests were aggressively closing tabs, did a small fix to make it open the tabs it was closing.

Comment 5

[Rodrigo Silveira [:rsilveira] [:rodms]]

https://hg.mozilla.org/integration/fx-team/rev/008017679816

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/008017679816

Comment 7

[Rodrigo Silveira [:rsilveira] [:rodms]]

test
https://hg.mozilla.org/integration/fx-team/rev/c55088fba674

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c55088fba674