Closed Bug 891694 Opened 11 years ago Closed 11 years ago

Dump more of long JS strings when writing a GC log

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla25
Project Flags:
blocking-b2g leo+
Tracking Flags:
Tracking Status
firefox23 --- wontfix
firefox24 --- wontfix
firefox25 --- fixed
b2g18 --- fixed
b2g18-v1.0.0 --- wontfix
b2g18-v1.0.1 --- wontfix
b2g-v1.1hd --- fixed

People

(Reporter: justin.lebar+bug, Assigned: justin.lebar+bug)

References

(Blocks 1 open bug)

Details

(Whiteboard: [LeoVB+])

Attachments

(2 files)

Patch, v1
1.01 KB, patch
n.nethercote
: review+
Details | Diff | Splinter Review
Patch for b2g18, v1
851 bytes, patch
n.nethercote
: review+
Details | Diff | Splinter Review 
Right now we dump at most 1024 chars per line when doing a GC log.

1024 chars isn't necessarily enough to decode a data URI of a PNG into something recognizable.  I'd like to make this much longer -- maybe 32kb.
Attached patch Patch, v1 — — Splinter Review 

        Attachment #773056 -
        Flags: review?(n.nethercote)

    
    

    
  
I'm a bit concerned about allocating this much stack memory; I don't want us to overflow our stack.  Maybe it would be better to allocate it on the heap.

But it probably doesn't matter; the worst that happens is we crash, and this doesn't get triggered unless you ask for it.

        Attachment #773056 -
        Flags: review?(n.nethercote) → review+
Assignee: general → justin.lebar+bug
Blocks: 723783

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/812075ed2f63
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25

    
    

    
  
This will aide in debugging b2g failures.
blocking-b2g: --- → leo+

    
    

    
  
Needs a branch-specific patch for uplift.

          status-b2g18:
          --- → affected

          status-b2g18-v1.0.0:
          --- → wontfix

          status-b2g18-v1.0.1:
          --- → wontfix

          status-b2g-v1.1hd:
          --- → affected

          status-firefox23:
          --- → wontfix

          status-firefox24:
          --- → wontfix

          status-firefox25:
          --- → fixed
Flags: needinfo?(justin.lebar+bug)
Keywords: branch-patch-needed

    
  

        Attachment #774898 -
        Attachment description: Dump more of long strings when writing a GC log. → Patch for b2g18, v1

        Attachment #774898 -
        Flags: review?(n.nethercote)

    
  
Flags: needinfo?(justin.lebar+bug)

        Attachment #774898 -
        Flags: review?(n.nethercote) → review+

    
  
Whiteboard: [LeoVB+]

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: