Closed Bug 891697 Opened 11 years ago Closed 11 years ago

Prettier printing for MIR structures

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla25

People

(Reporter: sunfish, Unassigned)

References

Details

Attachments

(1 file)

Attached patch a proposed fixSplinter Review
Following on 883570, this patch adds a dump method to MDefinition which calls printName and printOpcode, both of which are relevant when debugging. This will replace printOpcode in the "Hacking Tips" wiki [0].

Also, it adds a block label to MBasicBlock's dump method, which is especially useful when the full graph is printed.

[0] https://developer.mozilla.org/en-US/docs/SpiderMonkey/Hacking_Tips
Attachment #773063 - Flags: review?(nicolas.b.pierron)
Attachment #773063 - Flags: review?(nicolas.b.pierron) → review+
https://hg.mozilla.org/mozilla-central/rev/0a5bbf2f4b1e
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: