Prettier printing for MIR structures

RESOLVED FIXED in mozilla25

Status

()

Core
JavaScript Engine
--
enhancement
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: sunfish, Unassigned)

Tracking

Trunk
mozilla25
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
Created attachment 773063 [details] [diff] [review]
a proposed fix

Following on 883570, this patch adds a dump method to MDefinition which calls printName and printOpcode, both of which are relevant when debugging. This will replace printOpcode in the "Hacking Tips" wiki [0].

Also, it adds a block label to MBasicBlock's dump method, which is especially useful when the full graph is printed.

[0] https://developer.mozilla.org/en-US/docs/SpiderMonkey/Hacking_Tips
Attachment #773063 - Flags: review?(nicolas.b.pierron)
Attachment #773063 - Flags: review?(nicolas.b.pierron) → review+
(Reporter)

Comment 1

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/0a5bbf2f4b1e

Comment 2

4 years ago
https://hg.mozilla.org/mozilla-central/rev/0a5bbf2f4b1e
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.