891706 - crash in mozilla::dom::MediaRecorder::CheckPrincipal() when closing a tab while recording is started

Status: VERIFIED FIXED

(Core :: Audio/Video: Recording, defect)

Description

[Jason Smith [:jsmith]]

Attachment: Test Case

This bug was filed from the Socorro interface and is 
report bp-4ae59820-2b2e-4b6e-b7e8-8ffeb2130710 .
 ============================================================= 

STR

1. Load attached test case in a tab and have something else opened in a different tab
2. In console, run mediaRecorder.start();
3. Close the tab

Expected

We should shutdown the media recording gracefully.

Actual

Firefox crashes.

Comment 1

[Jason Smith [:jsmith]]

Should note there's one extra step there - make sure you accept permissions on Desktop Firefox when the gUM prompt appears.

Comment 2

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

Attachment: patch v1

add check for GetOwner()

Comment 3

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

Attachment: check in patch

carry reviewer.

Comment 4

[Scoobidiver (away)]

Tweaking the signature to workaround bug 865146.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2ba16b8a7f52

Any way to test this?

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/2ba16b8a7f52

Comment 7

[Jason Smith [:jsmith]]

The tab case appears to no longer reproduce a crash with this patch. However, I'm now noticing that the firefox.exe process will not shutdown if Firefox is quit while recording is started. Filed bug 894134 to track this.