891710 - Flag names are not hyperlinks if multiple flags were set at the same time.

Status: RESOLVED FIXED

(bugzilla.mozilla.org Graveyard :: Extensions: InlineHistory, defect)

Description

[Simon Green]

Attachment: v1 patch

(taken from the original bug report in BRC)

Description of problem:
Bugzilla sometimes shows flag names as hyperlinks to the history (showing when the flag was set and by whom), while other times it shows the same flag names as plain text.  The behaviour seems to depend on whether a bug has multiple flags set at the same time, in which case the flags are not shown as links.

Version-Release number of selected component (if applicable):
4.4

How reproducible:
Always.

Steps to Reproduce:
1. View https://bugzilla.redhat.com/show_bug.cgi?id=670818.
2. Observe that the hss_devel_ack and hss_qa_ack flags are displayed as hyperlinks.
3. Scroll down the history of bug 670818.  Observe that the hss_devel_ack and hss_qa_ack flags were most recently set at different times.
4. View https://bugzilla.redhat.com/show_bug.cgi?id=962654.
5. Observe that the hss_devel_ack and hss_qa_ack flags are not displayed as hyperlinks.
6. Scroll down the history of bug 962654.  Observe that the three ack flags were most recently set at the same time.

Actual results:
The bug with flags set individually shows the flag names as hyperlinks.  The bug with multiple flags set at the same time shows the flag names as plain text.

Expected results:
Flag names should be shown as hyperlinks regardless of whether the flags were set one at a time or all at once.

Comment 1

[Simon Green]

Should mention that this patch has been tested on brc, but not bmo.

Comment 2

[:glob ✱]

Comment on attachment 773076 [details] [diff] [review]
v1 patch

r=glob

Comment 3

[:glob ✱]

Committing to: bzr+ssh://[e-mail]/bmo/4.2/
modified extensions/InlineHistory/template/en/default/hook/bug/comments-aftercomments.html.tmpl
Committed revision 9126.

Committing to: bzr+ssh://[e-mail]/bugzilla/extensions/InlineHistory/trunk/
modified template/en/default/hook/bug/comments-aftercomments.html.tmpl
Committed revision 6.