891728 - [email] image attachments regressed on master by AMDification; dynamic require of shared/mime_mapper fails due to rel-path

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Andrew Sutherland [:asuth] (he/him)]

There are three highly rel-pathed mappings in mail_app.js; 2 l10n and one catch-all shared path which only seems to be used for mime_mapper.  That entry ends up like so in a GAIA_OPTIMIZE build, but is broken under all cases:
  shared: '../../../shared'

The l10n entries aren't a problem because build/email.build.js explicitly includes them.  I don't think we need to inline mime_mapper.js.

When the complete build finishes, we do also have a copy of the file in apps/email/shared/js/ because the generic gaia build system copies it over.

We should try and fix this immediately, although I could imagine the ideal solution won't come until e-mail can handle more of its packaging steps itself.


To repro, try and look at any e-mail with attachments on gaia/master; the attachments won't be listed and you will see a timeout error from alameda eventually.

Comment 1

[James Burke [:jrburke]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10876

Pointer to Github pull-request

Comment 2

[James Burke [:jrburke]]

Comment on attachment 773106 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10876

Fixes the module ID, set up export value from the global.

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 773106 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10876

Thanks for the quick fix! r=asuth

Comment 4

[James Burke [:jrburke]]

Merged on gaia master:

https://github.com/mozilla-b2g/gaia/commit/2ef104ed25f17dedd80e99d9f07601c466685519