Use inverted icons for buttons moved to the menubar on Windows 7 glass

RESOLVED FIXED in Firefox 28

Status

()

Firefox
Toolbars and Customization
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Gijs, Assigned: Gijs)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 28
x86_64
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [Australis:P4][Australis:M9])

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
The 'normal' icons aren't really visible because of the lack of contrast if the area behind the glass is dark. Inverted icons are what's used in Nightly, and those seem to work, contrast-wise, even if the glass window is over a pure white background.
(Assignee)

Comment 1

5 years ago
Created attachment 819698 [details] [diff] [review]
part 0: fix alltabs-button styling,

So when I fixed bug 878551 I should probably alread have done this. Oops.
Attachment #819698 - Flags: review?(mnoorenberghe+bmo)
(Assignee)

Updated

5 years ago
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
(Assignee)

Comment 2

5 years ago
Created attachment 819700 [details] [diff] [review]
invert toolbarbutton icons in tabstrip and menubar,

And here's an actual fix for this issue.
Attachment #819700 - Flags: review?(mnoorenberghe+bmo)
(Assignee)

Comment 3

5 years ago
(I needed the alltabs fix because otherwise they were showing the entire Toolbar-inverted iconset because these rules are more specific than the existing alltabs-button rules. The button is constrained to the tabstoolbar now that bug 878551 is fixed, so there's no point in having the extra child selector stuff in those rules, so I fixed them)
Attachment #819698 - Flags: review?(mnoorenberghe+bmo) → review+
Comment on attachment 819700 [details] [diff] [review]
invert toolbarbutton icons in tabstrip and menubar,

Review of attachment 819700 [details] [diff] [review]:
-----------------------------------------------------------------

Please indicate in the commit message that the change is only for Aero Glass.

r=me with the following caveat

::: browser/themes/windows/browser-aero.css
@@ +148,5 @@
> +  #toolbar-menubar > toolbarpaletteitem > :-moz-any(@primaryToolbarButtons@):not(:-moz-lwtheme),
> +  #toolbar-menubar > :-moz-any(@primaryToolbarButtons@):not(:-moz-lwtheme),
> +  #TabsToolbar > toolbarpaletteitem > :-moz-any(@primaryToolbarButtons@):not(:-moz-lwtheme),
> +  #TabsToolbar > :-moz-any(@primaryToolbarButtons@):not(:-moz-lwtheme) {
> +    list-style-image: url("chrome://browser/skin/Toolbar-inverted.png");

It seems like this should be moved below to the -moz-windows-glass section otherwise this will also affect Windows 8+ where I would guess the same problem doesn't occur. 
(The whole  -moz-windows-compositor block needs to be checked for things that should move to -moz-windows-glass to fix colours on Windows 8).
Attachment #819700 - Flags: review?(mnoorenberghe+bmo) → review+
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/projects/ux/rev/4094b21e7f42
https://hg.mozilla.org/projects/ux/rev/4054d25dfacd (with fixed commit msg and rules in the -glass box media query rather than the compositor one)
Whiteboard: [Australis:P4] → [Australis:P4][Australis:M9][fixed-in-ux]
(Assignee)

Comment 6

5 years ago
https://hg.mozilla.org/mozilla-central/rev/4094b21e7f42
https://hg.mozilla.org/mozilla-central/rev/4054d25dfacd
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P4][Australis:M9][fixed-in-ux] → [Australis:P4][Australis:M9]
Target Milestone: --- → Firefox 28
You need to log in before you can comment on or make changes to this bug.