891893 - When you drag and drop the same web site icon with SM 2.19 to a location where a generic web site icon was created pre-SM2.19, the web site icon remains generic instead of changing to a Seamonkey icon

Status: RESOLVED WORKSFORME

(SeaMonkey :: OS Integration, defect)

Description

[Arthur K. (he/him)]

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:23.0) Gecko/20100101 Firefox/23.0 SeaMonkey/2.20 (Beta/Release)
Build ID: 20130708004249

Steps to reproduce:

I had a web site shortcut that was created pre-SM 2.19 to http://goo.gl/wP8AD in a folder that displayed as a generic icon. I visited this site with 2.19 and dragged the web site icon to overwrite the generic icon hoping it would change to the Seamonkey shortcut icon but it did not. I tried with SM2.20b1 with the same result. 

Even though overwriting the old icon with a new did not change it to a Seamonkey icon, here's the bizarre part: If I rename the newly overwritten shortcut to something else (i.e., foo), it *does* change to a Seamonkey icon.

Some additional information that may be of use.

1) If I drag the site icon to some *other* location, the Seamonkey icon does appear.
2) If I delete the generic icon created pre-SM 2.19 and then try to drag a new site icon to the same location where I deleted the generic icon, it will still display a generic icon instead of a Seamoney icon. However, renaming the shortcut will change it to a Seamonkey icon. It seems Seamonkey is somehow remembering or holding information about the original location and original generic icon....somewhere.


Actual results:

The icon did not change to the Seamonkey icon but instead remained a generic icon.


Expected results:

The icon should have changed to the Seamonkey icon from a generic icon.

Comment 1

[Philip Chee]

This appears to be intended. See Bug 828284 Comment 1:
> The ability to read PNG images from ICO and CUR format images was introduced in Windows
> Vista, Windows XP can't cope with such files and replace the icon with the default
> windows system icon

Comment 2

[exie]

This particular problem is kinda different from bug 828284 but it is the result of that very bug tho. Shortcut created by SM2.19 has correct format but icon stay generic. I guess it is Windows related not Mozilla.

Comment 3

[Arthur K. (he/him)]

(In reply to Philip Chee from comment #1)
> This appears to be intended. See Bug 828284 Comment 1:
> > The ability to read PNG images from ICO and CUR format images was introduced in Windows
> > Vista, Windows XP can't cope with such files and replace the icon with the default
> > windows system icon
> 
> *** This bug has been marked as a duplicate of bug 828284 ***

So what explains the icon changing from generic icon to Seamonkey icon if the link name is simply renamed?

Comment 4

[Philip Chee]

> So what explains the icon changing from generic icon to Seamonkey icon if the link name
> is simply renamed?
Good point. Should I un-DUP this bug then?
If you go to about:config and filter for "browser.shell.shortcutFavicons". What is this set to?

Comment 5

[Philip Chee]

Also see https://support.mozilla.org/en-US/questions/943001#answer-436894

Comment 6

[Arthur K. (he/him)]

(In reply to Philip Chee from comment #4)
> > So what explains the icon changing from generic icon to Seamonkey icon if the link name
> > is simply renamed?
> Good point. Should I un-DUP this bug then?
> If you go to about:config and filter for "browser.shell.shortcutFavicons".
> What is this set to?

Well, this is strange. I am not seeing "browser.shell.shortcutFavicons" in my about:config when I filter for it. I don't know that it matters but I am on SM 2.20b2 (build 20130721212612). Should I add it manually and see what happens?

Comment 7

[Arthur K. (he/him)]

(In reply to Philip Chee from comment #5)
> Also see https://support.mozilla.org/en-US/questions/943001#answer-436894

Thanks for that info. Pref added manually and set to false.

While I no longer have the generic icons to overwrite when I originally submitted the bug, dragging any site icon to the folder location I've been using that *used* to have the generic icons now show normal Seamonkey icons so *maybe* this fixed what I was seeing. I say that because when visiting the Release Management page (http://goo.gl/diqF8) and dragging the site icon it would *always* be generic. Now, whether I drag the icon of the current, previous, or next month, it's a proper Seamonkey icon.

So with the pref at false, I hesitantly say it WFM.

Comment 8

[exie]

First same problem is still valid for Firefox 22.0 under Windows XP.
I have browser.shell.shortcutFavicons set to false since patch release.
I still have few shortcuts created before the bug 828284 was solved and patch released. Now if I open such old shortcut in FF 
> [InternetShortcut]
> URL=http://www.overclock.net/t/1245883/which-ssd-to-get-intel-ssd-120gb-520-330-or-vertex-4
> IDList=
> HotKey=0
> IconFile=C:\Documents and Settings\xxx\Local Settings\Application Data\Mozilla\Firefox\Profiles\tz0ih65k.default\shortcutCache\bDfpHhVVhLsm4sPbkip9HA==.ico
IconIndex=0

and re-create the shortcut to the exact same place, the shortuct will have "correct" format 
> [InternetShortcut]
> URL=http://www.overclock.net/t/1245883/which-ssd-to-get-intel-ssd-120gb-520-330-or-vertex-4

but the icon stay generic instead of changing to FF icon. I repeat I don't think it has anything to do with FF or SM but Windows itself...

Comment 9

[Arthur K. (he/him)]

(In reply to exie from comment #8)
> First same problem is still valid for Firefox 22.0 under Windows XP.
> I have browser.shell.shortcutFavicons set to false since patch release.
> I still have few shortcuts created before the bug 828284 was solved and
> patch released. Now if I open such old shortcut in FF 
> > [InternetShortcut]
> > URL=http://www.overclock.net/t/1245883/which-ssd-to-get-intel-ssd-120gb-520-330-or-vertex-4
> > IDList=
> > HotKey=0
> > IconFile=C:\Documents and Settings\xxx\Local Settings\Application Data\Mozilla\Firefox\Profiles\tz0ih65k.default\shortcutCache\bDfpHhVVhLsm4sPbkip9HA==.ico
> IconIndex=0
> 
> and re-create the shortcut to the exact same place, the shortuct will have
> "correct" format 
> > [InternetShortcut]
> > URL=http://www.overclock.net/t/1245883/which-ssd-to-get-intel-ssd-120gb-520-330-or-vertex-4
> 
> but the icon stay generic instead of changing to FF icon. I repeat I don't
> think it has anything to do with FF or SM but Windows itself...

And what happens when you change the title of the shortcut by adding, say, another letter or number to the end of it? Does it stay generic or change to a proper SM icon?

Comment 10

[exie]

yes, that will change the icon to proper SM/FF icon, thats why I think it is Windows related.

Comment 11

[Arthur K. (he/him)]

Well, it seems to be working in SM 2.21b3 (20130908220716) due to the work done in bug 828284. Marking WFM.