Closed Bug 891914 Opened 12 years ago Closed 12 years ago

Localize /event-guides on webmaker.org

Categories

(Webmaker Graveyard :: webmaker.org, defect)

Product:
Webmaker Graveyard
Component:
webmaker.org
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: alicoding, Assigned: igoryen)

References

Details

(Whiteboard: wb.localization)

Attachments

(1 file, 1 obsolete file)

https://github.com/mozilla/webmaker.org/pull/257
48 bytes, text/x-github-pull-request
humph
: review-
alicoding
: review+
michiel
: review+
Details | Review
Localize /event-guides on webmaker.org
Assignee: nobody → igor.yentaltsev
Status: NEW → ASSIGNED
Whiteboard: wb.localization
Attachment #773542 - Flags: review?(schranz.m)
Attachment #773542 - Flags: review?(david.humphrey)
Comment on attachment 773542 [details] [review] https://github.com/mozilla/webmaker.org/pull/257 https://github.com/mozilla/webmaker.org/pull/257
Attachment #773542 - Attachment description: https://github.com/igoryen/webmaker.org/pull/2 → https://github.com/mozilla/webmaker.org/pull/257
Depends on: 891491
Attachment #773542 - Attachment is obsolete: true
Attachment #773542 - Flags: review?(schranz.m)
Attachment #773542 - Flags: review?(david.humphrey)
Attachment #774264 - Flags: review?(schranz.m)
Attachment #774264 - Flags: review?(david.humphrey)
Comment on attachment 774264 [details] [review] https://github.com/mozilla/webmaker.org/pull/257 This is looking good. Some issues to sort out in the PR. I can look again when that's done.
Attachment #774264 - Flags: review?(david.humphrey) → review-
Attachment #774264 - Flags: review?(schranz.m)
Attachment #774264 - Flags: review?(pomax)
Attachment #774264 - Flags: review?(ali)
Comment on attachment 774264 [details] [review] https://github.com/mozilla/webmaker.org/pull/257 This needs a decent amount of whitespace/alignment cleaning. I'm also not sure we need the ' and " entities in the strings. If this comes straight from transifex, then it's not something we control, but if this was a hand-made file, let's replace these with ' and ", making sure to slash-escape quotes that would otherwise break syntax.
Attachment #774264 - Flags: review?(pomax) → review-
Attachment #774264 - Flags: review- → review?(pomax)
Comment on attachment 774264 [details] [review] https://github.com/mozilla/webmaker.org/pull/257 please address all the issue first before re-requesting a PR. There's still several issues ali flagged that need fixing. Happy to review, but only after all issues are address (either fixed or invalidated =)
Attachment #774264 - Flags: review?(pomax) → review-
Attachment #774264 - Flags: review- → review?(pomax)
Comment on attachment 774264 [details] [review] https://github.com/mozilla/webmaker.org/pull/257 one styling nit (spacing), but also a note on duplicate keys still. We probably want to sort the key/value object on keys alphabetically, so that we can easily find keys, and easily spot duplicates.
Attachment #774264 - Flags: review?(pomax) → review-
Attachment #774264 - Flags: review?(kieran.sedgwick)
Attachment #774264 - Flags: review?(kieran.sedgwick)
Attachment #774264 - Flags: review?(pomax)
Attachment #774264 - Flags: review?
Attachment #774264 - Flags: review-
Comment on attachment 774264 [details] [review] https://github.com/mozilla/webmaker.org/pull/257 looks good. r+
Attachment #774264 - Flags: review?(pomax) → review+
Comment on attachment 774264 [details] [review] https://github.com/mozilla/webmaker.org/pull/257 Couple of things that needs to be fix and need to confirm that nothing breaks before landing this.
Attachment #774264 - Flags: review?(ali)
Attachment #774264 - Flags: review?
Attachment #774264 - Flags: review-
Attachment #774264 - Flags: review- → review?(ali)
Comment on attachment 774264 [details] [review] https://github.com/mozilla/webmaker.org/pull/257 r+ from me just make sure one more time if nothing is missing or breaking :)
Attachment #774264 - Flags: review?(ali) → review+
Have just rechecked and everything is fine.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Attachment mime type: text/plain text/plain → text/x-github-pull-request text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: