Closed Bug 891954 Opened 8 years ago Closed 7 years ago

Missing TabChild with SetCookieString

Categories

(Core :: Networking: Cookies, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla25

People

(Reporter: evilpie, Assigned: billm)

References

Details

Attachments

(2 files, 1 obsolete file)

Attached file stacktrace
No description provided.
Jason, do we want to disable IPC security checks for desktop e10s?
Flags: needinfo?(jduell.mcbugs)
(In reply to Josh Matthews [:jdm] from comment #1)
> Jason, do we want to disable IPC security checks for desktop e10s?

The general goal, security-wise, is that the security properties of B2G and e10s-Firefox should be approximately the same. So, I would expect that the same security checks should be used on all platforms. So, it would be good to know more about the cause of this issue before we do any wallpapering over it.
The security property we provide with B2G necko IPC security checks is that we prevent different apps from meddling with each other's cookies/cache/etc.  If e10s desktop doesn't have any concept of different apps then I'm OK with disabling the checks there.
Flags: needinfo?(jduell.mcbugs)
We can load all kind of different webpages in on content process, so I think this is probably different from B2G where one app owns one process? I will remove this check from the larch branch, because it triggers quite often while changing pages.
Attached patch necko patch (obsolete) — Splinter Review
This patch disables the checks. We'd like to get this on trunk so that it's possible to use electrolysis by flipping a pref.
Assignee: nobody → wmccloskey
Status: NEW → ASSIGNED
Attachment #781268 - Flags: review?(jduell.mcbugs)
Attached patch necko patch v2Splinter Review
Jason suggested a better way of doing this by flipping the existing pref in desktop configurations.
Attachment #781268 - Attachment is obsolete: true
Attachment #781268 - Flags: review?(jduell.mcbugs)
Attachment #781293 - Flags: review?(jduell.mcbugs)
Comment on attachment 781293 [details] [diff] [review]
necko patch v2

Review of attachment 781293 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/app/profile/firefox.js
@@ +1274,5 @@
>  // The request URL of the GeoLocation backend.
>  pref("geo.wifi.uri", "https://www.googleapis.com/geolocation/v1/geolocate?key=%GOOGLE_API_KEY%");
> +
> +// These security checks only apply in b2g. We want to disable them on desktop
> +// so that electrolysis works.

change to 

 // Necko IPC security checks only needed for app isolation for cookies/cache/etc:
 // currently irrelevant for desktop e10s
Attachment #781293 - Flags: review?(jduell.mcbugs) → review+
Comment on attachment 781293 [details] [diff] [review]
necko patch v2

Review of attachment 781293 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/app/profile/firefox.js
@@ +1275,5 @@
>  pref("geo.wifi.uri", "https://www.googleapis.com/geolocation/v1/geolocate?key=%GOOGLE_API_KEY%");
> +
> +// These security checks only apply in b2g. We want to disable them on desktop
> +// so that electrolysis works.
> +pref("network.disable.ipc.security", false);

Oh, and you want disable == "true" here :)
https://hg.mozilla.org/mozilla-central/rev/44b9c2407781
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.