Closed
Bug 891984
Opened 11 years ago
Closed 11 years ago
contacts in favorites sometimes not rendered
Categories
(Firefox OS Graveyard :: Gaia::Contacts, defect)
Tracking
(blocking-b2g:koi+)
RESOLVED
FIXED
| blocking-b2g | koi+ |
People
(Reporter: bkelly, Assigned: bkelly)
References
Details
(Whiteboard: [ c= p=2 ])
Attachments
(1 file)
After bug 879299 favorites are now sometimes not rendered. This happens because the favorite group is not recognized properly from the visibility_monitor callback because it always looks at the contact's main group. The first 7 contacts in favorites will be rendered, though, because we immediately render enough to show on the screen. I have a fix ready, but would like to write a unit test to check this case.
|
Assignee | |
Comment 1•11 years ago
|
||
Pull request with test case exposing the problem and fix to the code.
Attachment #773534 -
Flags: review?(crdlc)
|
|
Assignee | |
Updated•11 years ago
|
Attachment #773534 -
Attachment mime type: text/plain → text/html
|
||
Comment 2•11 years ago
|
||
Comment on attachment 773534 [details] Pull request at https://github.com/mozilla-b2g/gaia/pull/10902 Great work! Thanks a lot
Attachment #773534 -
Flags: review?(crdlc) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Thanks for the quick review! Merged: https://github.com/mozilla-b2g/gaia/commit/7d73558080444207f7170d194ac9905493604480
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•11 years ago
|
blocking-b2g: --- → koi?
|
||
Updated•11 years ago
|
blocking-b2g: koi? → koi+
You need to log in
before you can comment on or make changes to this bug.
Description
•