Closed Bug 891992 Opened 8 years ago Closed 8 years ago
remove LIVEWIRE from jsd
As far as I can tell, any LIVEWIRE related things in js/jsd aren't used any more. In fact, compiling with LIVEWIRE defined will fail, as js/jsd/jsd_scpt.cpp uses JS_Free, which doesn't exist (note capitalization).
Assignee: general → dkeeler
Status: NEW → ASSIGNED
Comment on attachment 773419 [details] [diff] [review] patch Review of attachment 773419 [details] [diff] [review]: ----------------------------------------------------------------- If you could insert a commit before this that fixes JS_free so that we could have an EOL tag (assuming it actually works w/ that), it'd be appreciated. - if not, a Bugzilla note (comment or bug) indicating that jsd-livewire didn't work even w/ that change would be nice. Unrelated, but if you're adopting jsd, it'd be nice if `item` was fixed here (unrelated commit): * Add a new item for a given URL. If an iten already exists for the given URL
Attachment #773419 - Flags: review+
Unfortunately, compiling with LIVEWIRE defined gave me this: 7:56.52 nsXPConnect.cpp 7:56.90 In file included from ../../../dist/include/jsdIDebuggerService.h:19:0, 7:56.90 from /home/keeler/mozilla-central/js/xpconnect/src/nsXPConnect.cpp:32: 7:56.90 ../../../dist/include/jsdebug.h:17:22: fatal error: lwdbgapi.h: No such file or directory 7:56.90 compilation terminated. lwdbgapi.h doesn't seem to exist anywhere, so jsd-livewire is much more broken than just the JS_Free issue.
Updated patch to include removing a local variable that already wasn't being used, but now really, really isn't being used. Carrying over r+.
Patch to fix the typo. I'm not filing a new bug to conserve electrons or something. I'm also assuming the request to fix the typo is a sufficient r+.
Attachment #773546 - Flags: review+
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.