891992 - remove LIVEWIRE from jsd

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Dana Keeler (she/her) (use needinfo) (:keeler for reviews)]

As far as I can tell, any LIVEWIRE related things in js/jsd aren't used any more. In fact, compiling with LIVEWIRE defined will fail, as js/jsd/jsd_scpt.cpp uses JS_Free, which doesn't exist (note capitalization).

Comment 1

[Dana Keeler (she/her) (use needinfo) (:keeler for reviews)]

Attachment: patch

Comment 2

[timeless]

Comment on attachment 773419 [details] [diff] [review]
patch

Review of attachment 773419 [details] [diff] [review]:
-----------------------------------------------------------------

If you could insert a commit before this that fixes JS_free so that we could have an EOL tag (assuming it actually works w/ that), it'd be appreciated.
- if not, a Bugzilla note (comment or bug) indicating that jsd-livewire didn't work even w/ that change would be nice.

Unrelated, but if you're adopting jsd, it'd be nice if `item` was fixed here (unrelated commit):
 * Add a new item for a given URL. If an iten already exists for the given URL

Comment 3

[Dana Keeler (she/her) (use needinfo) (:keeler for reviews)]

Unfortunately, compiling with LIVEWIRE defined gave me this:

7:56.52 nsXPConnect.cpp
7:56.90 In file included from ../../../dist/include/jsdIDebuggerService.h:19:0,
7:56.90                  from /home/keeler/mozilla-central/js/xpconnect/src/nsXPConnect.cpp:32:
7:56.90 ../../../dist/include/jsdebug.h:17:22: fatal error: lwdbgapi.h: No such file or directory
7:56.90 compilation terminated.

lwdbgapi.h doesn't seem to exist anywhere, so jsd-livewire is much more broken than just the JS_Free issue.

Comment 4

[Dana Keeler (she/her) (use needinfo) (:keeler for reviews)]

Attachment: patch v1.1

Updated patch to include removing a local variable that already wasn't being used, but now really, really isn't being used. Carrying over r+.

Comment 5

[Dana Keeler (she/her) (use needinfo) (:keeler for reviews)]

Attachment: patch for typo

Patch to fix the typo. I'm not filing a new bug to conserve electrons or something. I'm also assuming the request to fix the typo is a sufficient r+.

Comment 6

[Dana Keeler (she/her) (use needinfo) (:keeler for reviews)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d0eb29dc7f51
https://hg.mozilla.org/integration/mozilla-inbound/rev/faa78d7c3c42

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/d0eb29dc7f51
https://hg.mozilla.org/mozilla-central/rev/faa78d7c3c42