Closed Bug 892014 Opened 6 years ago Closed 6 years ago

[jsdbg2] Remove misleading arguments to handleUncaughtException

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla25

People

(Reporter: jimb, Unassigned)

Details

Attachments

(1 file)

If the 'callHook' parameter to Debugger::handleUncaughtException is false, then the 'vp' argument is never used. Confusingly, various places in the source pass a non-NULL value pointer and false for callHook.

The attached patch changes these uses to omit the 'vp' argument altogether.
Attachment #773438 - Flags: review?(jorendorff)
Comment on attachment 773438 [details] [diff] [review]
Don't pass the 'vp' argument to handleUncaughtException if it's just going to be ignored.

Review of attachment 773438 [details] [diff] [review]:
-----------------------------------------------------------------

I'd like to see a separate name for this; then the code can be simplified a little...?

I dunno, it's very confusing the way this is written right now. I get lost every time I look at it.
Attachment #773438 - Flags: review?(jorendorff) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/21065e562a56
Status: NEW → ASSIGNED
Flags: in-testsuite-
Target Milestone: --- → mozilla25
https://hg.mozilla.org/mozilla-central/rev/21065e562a56
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.