892038 - It should be possible to add new prefs in about:config even after searching

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: General, defect)

Description

[Sam Foster [:sfoster] (he/him)]

Currently when you initially load about:config, there is a row at the top if the list that allows you to create new preferences. If you use the search box, that goes away. 
Searching for a pref, not finding it and needing to create is is a normal sequence we should support, so clearing/dismissing the search should not remove that create-preference form.

Comment 1

[Allison Naaktgeboren :ally]

Attachment: aboutconfigdissappearingbar

This is a holdover from the fennec codebase. We don't have to worry about screen space, and have no need to hide the editor bar, so let's not.

Comment 2

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 788444 [details] [diff] [review]
aboutconfigdissappearingbar

Review of attachment 788444 [details] [diff] [review]:
-----------------------------------------------------------------

Easiest review evar. Looks good, works well.

::: browser/metro/base/content/config.js
@@ +34,5 @@
>      window.removeEventListener("prefnew", this, false);
>    },
>  
>    filter: function filter(aValue) {
>      let row = document.getElementById("editor-row");

ha ha ha :)

Comment 3

[Allison Naaktgeboren :ally]

protip: remember to actually *push* your patches after the r+

 https://hg.mozilla.org/integration/fx-team/rev/115594122709

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/115594122709