892047 - [Nightly][SMS] Strict mode warnings are errors in nightly 25

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Eric O'Connor [:oconnore]]

Development on nightly is currently broken due to the following strict mode errors:

[15:24:34.519] SyntaxError: test for equality (==) mistyped as assignment (=)? @ http://sms.gaiamobile.org:8080/js/contacts.js:44
[15:24:34.541] TypeError: function mm_resendMessage does not always return a value @ http://sms.gaiamobile.org:8080/js/message_manager.js:418
[15:24:34.636] SyntaxError: test for equality (==) mistyped as assignment (=)? @ http://sms.gaiamobile.org:8080/js/thread_list_ui.js:244
[15:24:34.686] TypeError: anonymous function does not always return a value @ http://sms.gaiamobile.org:8080/js/utils.js:503
[15:24:34.718] SyntaxError: test for equality (==) mistyped as assignment (=)? @ http://sms.gaiamobile.org:8080/js/thread_ui.js:404
[15:24:34.718] TypeError: function thui_messageComposerTypeHandler does not always return a value @ http://sms.gaiamobile.org:8080/js/thread_ui.js:408
[15:24:34.753] SyntaxError: test for equality (==) mistyped as assignment (=)? @ http://sms.gaiamobile.org:8080/js/link_helper.js:134
[15:24:34.755] TypeError: function readTextBlob does not always return a value @ http://sms.gaiamobile.org:8080/js/smil.js:147
[15:24:34.856] SyntaxError: test for equality (==) mistyped as assignment (=)? @ http://sms.gaiamobile.org:8080/js/desktop_contacts_mock.js:177
[15:24:34.856] TypeError: anonymous function does not always return a value @ http://sms.gaiamobile.org:8080/js/desktop_contacts_mock.js:187
[15:24:34.866] NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS: '[JavaScript Error: "this.initHelper is not a function" {file: "file:///home/ec/bocoup/gaia/profile-debug/extensions/activities/components/SystemMessageManager.js" line: 195}]' when calling method: [nsIDOMGlobalPropertyInitializer::init] @ http://sms.gaiamobile.org:8080/js/activity_handler.js:9

Comment 1

[Rick Waldron [:rwaldron]]

I don't see how development is broken, since these errors have existed forever. This isn't "strict mode", it's ancient "javascript.options.strict = true" being on by default for SpiderMonkey in Nightly.

Comment 2

[Rick Waldron [:rwaldron]]

Also, you can shut off "warnings" in developer console to hide this junk