370 bytes, text/html
1.01 KB, patch
|Details | Diff | Splinter Review|
In buildbot, we invoke gaia-ui-tests with 'python runtests.py ...'. This currently fails to run any tests, because of this block of code: if __name__ == "__main__": main() and the fact that runtests.py is defined as an entrypoint for gaiatest: entry_points=""" # -*- Entry points: -*- [console_scripts] gaiatest = gaiatest.runtests:main """, In effect, this means that __name__ is never "__main__" in runtests.py; instead it's "gaiatest". To get around this problem, we can add a cli.py to gaiatest that can be used to run the tests using 'python cli.py...'; calling 'gaiatest' directly (as our Jenkins jobs do) will still work normally as well.
Created attachment 773529 [details] Pointer to Github pull request: https://github.com/mozilla/gaia-ui-tests/pull/1088 Pointer to Github pull-request
Attachment #773529 - Flags: review?(dave.hunt)
Comment on attachment 773529 [details] Pointer to Github pull request: https://github.com/mozilla/gaia-ui-tests/pull/1088 r+ (merged)
Attachment #773529 - Flags: review?(dave.hunt) → review+
https://github.com/mozilla/gaia-ui-tests/commit/7f375e489b2ba25b05d0782d2e25539596b253ed Now we need to update the mozharness script, which I'm going to do using this same bug.
Created attachment 774077 [details] [diff] [review] Use cli.py instead of runtests.py when invoking gaiatests,
Attachment #774077 - Flags: review?(aki)
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.