892078 - Need new CLI entrypoint for gaia-ui-tests

Status: RESOLVED FIXED

Description

[Jonathan Griffin (:jgriffin)]

In buildbot, we invoke gaia-ui-tests with 'python runtests.py ...'.  This currently fails to run any tests, because of this block of code:

if __name__ == "__main__":
    main()

and the fact that runtests.py is defined as an entrypoint for gaiatest:

      entry_points="""
      # -*- Entry points: -*-
      [console_scripts]
      gaiatest = gaiatest.runtests:main
      """,

In effect, this means that __name__ is never "__main__" in runtests.py; instead it's "gaiatest".

To get around this problem, we can add a cli.py to gaiatest that can be used to run the tests using 'python cli.py...'; calling 'gaiatest' directly (as our Jenkins jobs do) will still work normally as well.

Comment 1

[Jonathan Griffin (:jgriffin)]

Created attachment 773529 [details]
Pointer to Github pull request: https://github.com/mozilla/gaia-ui-tests/pull/1088

Pointer to Github pull-request

Comment 2

[Dave Hunt [:davehunt] [he/him] ⌚️UTC]

Comment on attachment 773529 [details]
Pointer to Github pull request: https://github.com/mozilla/gaia-ui-tests/pull/1088

r+ (merged)

Comment 3

[Jonathan Griffin (:jgriffin)]

https://github.com/mozilla/gaia-ui-tests/commit/7f375e489b2ba25b05d0782d2e25539596b253ed

Now we need to update the mozharness script, which I'm going to do using this same bug.

Comment 4

[Jonathan Griffin (:jgriffin)]

Created attachment 774077 [details] [diff] [review]
Use cli.py instead of runtests.py when invoking gaiatests,

Comment 5

[Jonathan Griffin (:jgriffin)]

https://hg.mozilla.org/build/mozharness/rev/afd748cdd6eb

Comment 6

[Jonathan Griffin (:jgriffin)]

in production