892155 - contacts app could further delay order/search calculations

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

When the visibility_monitor was implemented I added a partial delay of the calculation of the order and search strings.  These are somewhat expensive due to the normalization that must occur.  Right now the calculation will happen when the element appears on screen or when the value is needed for searching/ordering.

There is no reason to force these calculations when the list elements appear on screen.  Deferring this logic should help make scrolling smoother and slightly speed up load (due to forced rendering of above the fold elements).

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Pull request at https://github.com/mozilla-b2g/gaia/pull/10903

Comment 2

[Cristian Rodriguez (:crdlc)]

Only one thing although I guess that you have taken in account it correctly, are you loading all info for searching when an user enters in search mode? Right now, I don't know when the info from Facebook is loaded but it is needed for the search (company, telephones, ...)

Thanks

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

Hi,

as Cristian commented we will need to wait till Facebook information is fully loaded to be able to search all the contacts.

Which leads me to the idea of, deferring/enabling the search once we receive the |onListRendered| (waiting also for the FB info to be loaded). Cristian please correct me if I'm wrong but we used to do this isnt?

Thanks!
F.

Comment 4

[Ben Kelly [:bkelly, not reviewing]]

The search string is calculated when search.js calls 'getSearchText()' for each node.  If this happens prior to the FB load, then it may not get the correct information.  Let me investigate as I was not aware of this concern.

One possible fix would be to clear the search string on FB load so that it gets recalculated the next time the user searches.

Comment 5

[Ben Kelly [:bkelly, not reviewing]]

After talking to Cristian on irc it appears the FB search problem may be a separate, bigger issue.  I wrote up bug 892461 to track it.

If possible I'd like to proceed with the deferring the search string calculation.  It maintains the current level of functionality and, if anything, should make it easier to fix bug 892461.

Does that sound reasonable Francisco?

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Taking into account the FB attribute search is currently broken, we can land this and follow up with bug 892461 as you comment.

Thanks a lot Ben!

Comment 7

[Ben Kelly [:bkelly, not reviewing]]

Thanks Francisco.  Merged:

  https://github.com/mozilla-b2g/gaia/commit/4f4fa7b94913bbe7550bfe434a1145d982812248