892195 - ESC should toggle the console split view open/closed

Status: VERIFIED FIXED

(DevTools :: General, defect)

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Once we allow the console to be available in other panels via a split view, ESC should toggle that split view open/closed.

Comment 1

[Brandon Benvie [:benvie]]

It probably shouldn't toggle it, no? It should probably just close it. If we want a toggle that shouldn't be ESC, it should be a specific hotkey.

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Chrome's will also open it, which is why I put that in this bug.

Comment 3

[Brian Grinstead [:bgrins]]

Fixed by Bug 862558

Comment 4

[Manuela Muntean [Away]]

Verified as fixed with the latest Nightly build from 2013-12-04, on: Win 8 64-bit, Ubuntu 13.10 32-bit and Mac OS X 10.9 (both 32-bit and 64-bit).

ESC toggles the console split view open/closed. I can see the console split view as shown here: https://bug862558.bugzilla.mozilla.org/attachment.cgi?id=828842 for all tools, excepting "Console".

Also, as Paul suggested, I've tried the following scenario, that works with success on all platforms mentioned above:

1. In latest Aurora, disable the Web Console
2. Start latest Nightly with the same profile
3. See ESC to disable/enable the split console still works (it does)

Please let me know if there is anything else that needs to be tested for this feature. Thanks!

Comment 5

[Manuela Muntean [Away]]

> ESC toggles the console split view open/closed. I can see the console split
> view as shown here:
> https://bug862558.bugzilla.mozilla.org/attachment.cgi?id=828842 for all
> tools, excepting "Console".
> 
> Also, as Paul suggested, I've tried the following scenario, that works with
> success on all platforms mentioned above:
> 
> 1. In latest Aurora, disable the Web Console
> 2. Start latest Nightly with the same profile
> 3. See ESC to disable/enable the split console still works (it does)

Retested all of the above, receiving the same results, with the Holly build from 2013-12-04, on: Win 8 64-bit, Mac OS X 10.9 and Ubuntu 13.04 64-bit.

Comment 6

[Manuela Muntean [Away]]

Verified as fixed with the latest Aurora, on: Win 8.1 64-bit, Ubuntu 13.10 32-bit and Mac OS X 10.8.5.