892221 - Clean up "Unsupported Test"s for Fennec

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P2)

Description

[Jordan Santell [:jsantell] [@jsantell]]

Several files manually abort Unsupported tests -- should use module meta data with comments where bugs are specified:

(addon-sdk)❤ [~VIRTUAL_ENV/test]update-places-tests-fennec ♥  grep -roi 'unsupported test' .
./test-addon-installer.js:Unsupported Test
./test-browser-events.js:Unsupported Test
./test-clipboard.js:Unsupported Test
./test-content-script.js:Unsupported Test
./test-content-symbiont.js:Unsupported Test
./test-content-worker.js:Unsupported Test
./test-tab-observer.js:Unsupported Test
./test-tab.js:Unsupported Test
./test-window-events.js:Unsupported Test
./test-window-loader.js:Unsupported Test
./test-window-observer.js:Unsupported Test
./test-window-utils-global-private-browsing.js:Unsupported Test
./test-window-utils-private-browsing.js:Unsupported Test
./test-window-utils.js:Unsupported Test

Example:

module.exports = {
225     "test Unsupported Test": function UnsupportedTest (assert) {¬               
226         assert.pass(¬
227           "Skipping this test until Fennec support is implemented." +¬
228           "See bug 789757");¬
229     }¬
230   }¬

Comment 1

[Jordan Santell [:jsantell] [@jsantell]]

Added "engines" metadata to the following for skipping on Fennec:

addon-installer (module)
clipboard (module)
tab-observer
window-utils-private-browsing (bug 809412)

Removed "Unsupported Test" catching because tests were passing/implemented.

browser-events
content-scripts
content-symbiont
content-worker
window-utils
window-events
window-loader


Allowing to fail:
test-tabs* (bug 809362)
window-observer (fails when several runs)

Comment 2

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: GH PR 1116

Comment 3

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 776816 [details]
GH PR 1116

Changing a lot of the custom not supported handling to module metadata

Comment 4

[Erik Vold [:erikvold] (please needinfo? me)]

Comment on attachment 776816 [details]
GH PR 1116

This branch needs cleaning, it's got 100+ commits in it that appear to be from master already.

Comment 5

[Jordan Santell [:jsantell] [@jsantell]]

Fennec tests are requiring a lot of branching prereqs, looked like a bad merge and reset. Should be good now!

Comment 6

[Erik Vold [:erikvold] (please needinfo? me)]

Comment on attachment 776816 [details]
GH PR 1116

Quite a few of these test appear to be opening and closing windows which could crash fennec, or leave fennec in an odd state for following tests, they should be skipped.

Comment 7

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 776816 [details]
GH PR 1116

Resubmitted with skipping tests that create new windows for Fennec. The main purpose of this PR is to be able to run tests against all modules with a cleaner slate to merge in the individual fixes after

Comment 8

[Erik Vold [:erikvold] (please needinfo? me)]

Comment on attachment 776816 [details]
GH PR 1116

It looks like a bunch of bugs can be closed by this, we should review all of the referenced bugs to make sure and update them if necessary too.

Thanks Jordan!

Comment 9

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/dbde9a818ee6481bfefa6209aa2c07e86a4196de
Bug 892221 cleanup unsupported tests in Fennec

https://github.com/mozilla/addon-sdk/commit/6c91ec983f8a79631e50ac24e6b28cb3e5e73f8b
Merge pull request #1116 from jsantell/make-clear-fennec-support

Fix Bug 892221 Clean up "Unsupported Test"s for Fennec, r=@erikvold

Comment 10

[[github robot]]

Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/6331509f5bacec2ed7b2dfd31658c3d47f5246b2
Bug 892221 cleanup unsupported tests in Fennec