892227 - Missing icons for apps under the "New" tab on marketplace homepage

Status: RESOLVED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P1)

Description

[krupa raj[:krupa]]

steps to reproduce:
1. Load https://marketplace.firefox.com/?sort=created&src=category-new
2. Notice the apps which are missing icons


observed behavior:
We seem to have a lot of apps with missing icons. Let's fix

a) existing apps with no icons
b) Make sure that app extraction works fine

Comment 1

[krupa raj[:krupa]]

Attachment: screenshot

Comment 2

[Mathieu Pillard [:mat]]

Maybe related to the celery issues we've been having ? https://bugzilla.mozilla.org/show_bug.cgi?id=889924

FWIW, as cvan mentioned on IRC, as a stopgap we have a script that re-fetches the icons for apps which are missing some. It's manage.py process_addons --task=fix_missing_icons

Comment 3

[Christopher Van Wiemeersch [:cvan]]

There's only one missing now: https://marketplace.firefox.com/app/palinkaapp?src=all-created

Comment 5

[Kumar McMillan [:kumar]]

When fixing this, we need o make sure videos are fixed too (bug 906638)

Comment 6

[Wil Clouser [:clouserw]]

Marking as a P2 and giving to Rob since he owns the blocker bug too.

Comment 7

[Fabricio Campos Zuardi]

still happening, more screenshots at https://github.com/fczuardi/showdown_counter/issues/5

Comment 8

[Christopher Van Wiemeersch [:cvan]]

(In reply to Fabricio Campos Zuardi from comment #7)
> still happening, more screenshots at
> https://github.com/fczuardi/showdown_counter/issues/5

As mentioned in comment 6, the fix for this is the dependency of this bug: bug 889924.

Comment 10

[Jaime Vega]

Mi Movistar Icon missing! both 64 and 128 are included in the zip file!

Comment 11

[Wil Clouser [:clouserw]]

(In reply to Jaime Vega from comment #10)
> Mi Movistar Icon missing! both 64 and 128 are included in the zip file!

Can you give us a screenshot?  That sounds unrelated to this bug.

Comment 12

[Christopher Van Wiemeersch [:cvan]]

I noticed Mi Movistar's icon was missing a few days ago, but it appears now:
https://marketplace.firefox.com/app/mi-movistar?src=search
http://cl.ly/image/0o2d40203O3N/Screen%20Shot%202013-10-17%20at%202.35.56%20PM.png

Comment 13

[Jaime Vega]

That's the spanish icon, I mean the LATAM one

Comment 14

[Jaime Vega]

Attachment: 2013-10-17-14-35-47.png

Comment 15

[Wil Clouser [:clouserw]]

Thanks for the screenshot.  Looks like it is the same bug (and this bug is still around anyway).  Rob - let us know if you need a hand.

Comment 16

[Jaime Vega]

Any news of this problem?

Comment 17

[Karen Ward [:kward]]

Sorry Jaime.  The team has a number of priority issues that take priority over this one.  The best case scenario will be a fix on Oct 29. Rob/Wil please advise if this is feasible.

Comment 18

[Rob Hudson [:robhudson]]

In the short-term, running:

./manage.py --settings=settings_local_mkt process_addons --task=fix_missing_icons

Will fix the missing icons.

We may have to investigate how/why these are slipping through.

Comment 19

[Rob Hudson [:robhudson]]

According to the logs one of the recent apps that managed to not have an icon attempted to call `fetch_icon` right after it was created, which sent the task to celery. The celery task then does a query to get the app back out of the database and ended up writing "[Webapp:469148] Webapp does not exist". So the task doesn't find the app in the database and then it quits.

I was thinking slave lag was to blame but looking at the task it is decorated with the @write decorator which uses master and disables caching so I'm at a loss.

Comment 20

[Rob Hudson [:robhudson]]

In IRC we've come to the conclusion that the problem is exactly this case that the docs mention:
http://docs.celeryproject.org/en/latest/userguide/tasks.html#database-transactions

Comment 21

[Rob Hudson [:robhudson]]

https://github.com/mozilla/zamboni/commit/37f8709 

To verify:
Submit an app. From submitting the manifest to editing the details the app should have found the icon. After submission and going public the app should have an icon.

We might want to try that a few times just to make sure all work successfully since this bug happened only on occasion.

Comment 22

[Rob Hudson [:robhudson]]

https://github.com/mozilla/zamboni/commit/37f8709 

To verify:
Submit an app. From submitting the manifest to editing the details the app should have found the icon. After submission and going public the app should have an icon.

We might want to try that a few times just to make sure all work successfully since this bug happened only on occasion.

Comment 23

[Victor Carciu]

I am not able to push apps to public because of https://bugzilla.mozilla.org/show_bug.cgi?id=931937 , but we still have apps without icons when accessing https://marketplace.firefox.com/?sort=created&src=category-new .
Please see screencast : http://screencast.com/t/mAoVssKOZ

Should we re-open the bug based on screencast from above?

Comment 24

[Rob Hudson [:robhudson]]

(In reply to Victor Carciu from comment #23)
> I am not able to push apps to public because of
> https://bugzilla.mozilla.org/show_bug.cgi?id=931937 , but we still have apps
> without icons when accessing
> https://marketplace.firefox.com/?sort=created&src=category-new .
> Please see screencast : http://screencast.com/t/mAoVssKOZ
> 
> Should we re-open the bug based on screencast from above?

This isn't on production yet. If there are any recent submissions on -dev with missing icons then yes, please re-open.

Comment 25

[krupa raj[:krupa]]

Attachment: touch11.zip

STR:
1. Upload the attached packaged app to stage
2. Notice that the app icon is not extracted by the time you are done adding additional details to the app during submission
3. Click on 'Manage my app' after submission

observed behavior:
No app icon @  https://marketplace.allizom.org/developers/app/touch-11i/edit OR https://marketplace.allizom.org/app/touch-11i/

Comment 26

[Felix E. Klee]

Attachment: Missing video thumbnail in Marketplace on Keon (Firefox OS 1.3)

Just added a screenshot showing a missing video thumbnail in
Marketplace. The screenshot was created on my Keon, running Firefox OS
1.3 nightly:

<http://downloads.geeksphone.com/keon/master/nightly-images-keon-master-2013-11-01.Gecko-d258654.Gaia-299e7ff.zip>

Note that in August, I created a separated issue concerning missing
video thumbnails, which was marked as duplicate of the current one:

<https://bugzilla.mozilla.org/show_bug.cgi?id=906638>

Comment 27

[Matt Basta [:basta]]

We should have fixed this last month. All image processing queues in the devhub were not processing tasks. It was an issue with the configuration of rabbitmq, IIRC.

Felix: please try re-uploading your screenshot, it should work now. If the issue persists, please let us know so we can open a new bug.

Comment 28

[Felix E. Klee]

@Matt Note that I did not have problems with screen shots, but with video thumbnails. Does the fix take care of that?

Comment 29

[Matt Basta [:basta]]

Felix: Either way, that would be a separate issue. Fixing the queue doesn't necessarily retroactively fix screenshots that were broken (especially if the task hit its expiration). Additionally, video is processed separately from images, so that wouldn't be this bug anyway. If it's still a problem, please file a new bug.

Comment 30

[Felix E. Klee]

> Either way, that would be a separate issue.

Just for the record: I submitted that as a separate issue (bug 906638), but it was merged into the current one.

Video upload is unfortunately entirely broken at the moment (bug 928242).

Comment 31

[Matt Basta [:basta]]

Thanks, we can track that issue over there.