892230 - Trying to submit a packaged app with an origin specified in the manifest that is not privileged fails to report a validation error

Status: VERIFIED FIXED

(Marketplace Graveyard :: Validation, defect, P3)

Description

[Jason Smith [:jsmith]]

Attachment: Test App

STR

1. Go to https://marketplace-dev.allizom.org/developers/submit/
2. Submit the attached app as a packaged app

Expected

We should get a validation error - web-based packaged apps are not allowed to have the origin property.

Actual

Validation passes. When you try to continue in the submission process, you get redirected back to https://marketplace-dev.allizom.org/developers/submit/. Strange.

Comment 1

[Christopher Van Wiemeersch [:cvan]]

If there's an `origin` and `type` is `web`, we should throw a validation error.

Comment 2

[Jason Smith [:jsmith]]

(In reply to Christopher Van Wiemeersch [:cvan] from comment #1)
> If there's an `origin` and `type` is `web`, we should throw a validation
> error.

Should also note that we should also throw a validation error if the origin is specified and no type is provided.

Comment 3

[Christopher Van Wiemeersch [:cvan]]

Basta says he's blocked on docs before adding this to the validator. Are there docs?

Comment 4

[Jason Smith [:jsmith]]

(In reply to Christopher Van Wiemeersch [:cvan] from comment #3)
> Basta says he's blocked on docs before adding this to the validator. Are
> there docs?

Not yet. bug 878094 is still open. Let me ping Mark for an update.

Comment 5

[Matt Basta [:basta]]

https://github.com/mozilla/app-validator/commit/461b979deeef0f869813710d5996c9f7885f4d28

Comment 6

[Iulian Timis]

Verified as fixed in https://marketplace-dev.allizom.org/developers/submit/ on FF26 (Win 7).
Postfix screencast http://screencast.com/t/lfNMC9rSEfZ9
Closing bug.